Skip to content

Test: add full payload JSON round-trip test in SystemStatusTests #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denizguney wants to merge 6 commits into
base: main
Choose a base branch
from
+14 −0
Open

Test: add full payload JSON round-trip test in SystemStatusTests #2221

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc00cce
Test: add full payload JSON round-trip test in SystemStatusTests
denizguney Aug 30, 2026
19e25a1
Add test for fullPayloadRoundTripsThroughJSON
denizguney Aug 31, 2026
cbaf690
Update SystemStatusTests.swift
denizguney Aug 31, 2026
2e32144
style: format SystemStatusTests.swift
denizguney Aug 31, 2026
f04d598
Merge branch 'main' into patch-4
denizguney Sep 2, 2026
a4bb1d5
Merge branch 'main' into patch-4
jglogan Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Tests/ContainerCommandsTests/SystemStatusTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,18 @@ struct SystemStatusTests {
let updated = Application.SystemStatus.withImageCount(resources, imageCount: nil)
#expect(updated?.images == nil)
}

@Test

@jglogan jglogan Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add one line of white space

func fullPayloadRoundTripsThroughJSON() throws {
let payload = makeRunningPayload(
paths: Application.PathInfo(appRoot: "/app", installRoot: "/install", logRoot: "/log"),
resources: Application.ResourceCounts(containersTotal: 10, containersRunning: 4)
)
let json = try Output.renderJSON(payload)
let decoded = try JSONDecoder().decode(Application.StatusPayload.self, from: Data(json.utf8))

#expect(decoded.paths?.appRoot == "/app")
#expect(decoded.resources?.containersTotal == 10)

@jglogan jglogan Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denizguney This seems quite specific. Is it provable that these values will hold under all conditions?

@denizguney denizguney Aug 31, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, these values are currently specific to this sample test payload. Our main goal here is to isolate and verify the correct parsing and type safety of the StatusPayload structure. However, I can make the test more robust or document that this is strictly a deterministic validation for this specific mock fixture. Let me know if you'd prefer a more dynamic approach or if adjusting the fixture assertions works best!"

@jglogan jglogan Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I got it wrong. I thought I was looking at CLI tests. This test looks fine, please just fix the little whitespace nit and we can merge it.

@denizguney denizguney Aug 31, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the whitespace nit. Thanks for the review

#expect(decoded.resources?.containersRunning == 4)
}
}