fix(xpc): reject unknown peer error codes - #2241
Open
stephenlclarke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The commit is signed and verified.
Type of Change
Motivation and Context
Closes #2240.
XPC error payloads cross both a process and a version boundary. Previously, decoding an error code that the receiver did not know called
ContainerizationError.Code(rawValue:), whose unknown-value path is afatalError. A newer daemon could therefore terminate an older client simply by returning a newly introduced error code.Validate the decoded description against the currently supported codes before constructing the error. Unknown codes now follow the existing malformed-peer-payload path and throw
.internalError; known codes and messages remain unchanged.Testing
Tested locally
Added/updated tests
Added/updated docs
Added and registered
ContainerXPCTestsinPackage.swift.swift test --filter XPCMessageTests: 2 tests passed, covering both an unknown peer code and every currently known code.git diff --check: passed.