Skip to content

Fix image push tests permissions in CI #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix image push tests permissions in CI #128

wants to merge 3 commits into from

Conversation

Siddhant-K-code
Copy link

Implemented a mock-based testing approach that validates push functionality without requiring external registry permissions.

fixes #56

@adityaramani
Copy link
Contributor

Thanks for the PR! Will take a deeper look and get back!

In the meantime could you please set up commit signing and re push your commits?

@Siddhant-K-code Siddhant-K-code force-pushed the fix/image-push-tests-permissions branch from 0b27707 to 825f0ad Compare June 14, 2025 18:15
@Siddhant-K-code
Copy link
Author

Thanks, I've signed the commit 825f0ad

@Siddhant-K-code Siddhant-K-code force-pushed the fix/image-push-tests-permissions branch from c2b4575 to f044c26 Compare June 14, 2025 18:34
@adityaramani adityaramani self-assigned this Jun 17, 2025
@Siddhant-K-code
Copy link
Author

👋🏻 @adityaramani, any progress on this?

@dcantah
Copy link
Member

dcantah commented Jul 7, 2025

Hi @Siddhant-K-code, please run make fmt and then re-push with the changes. CI is just whining on that

@Siddhant-K-code Siddhant-K-code force-pushed the fix/image-push-tests-permissions branch from 8b94a70 to 108db95 Compare July 7, 2025 20:45
@Siddhant-K-code Siddhant-K-code force-pushed the fix/image-push-tests-permissions branch from 108db95 to 4fac487 Compare July 7, 2025 21:15
adityaramani
adityaramani requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@adityaramani adityaramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay.

I like the update to the ImageStoreTests, but Im not sure about the RegistryClientTests

Do you want to back that out from the PR and we can re-think if there is a better way to do it?

adityaramani
adityaramani requested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@adityaramani adityaramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good! Just two small comments

@Siddhant-K-code Siddhant-K-code force-pushed the fix/image-push-tests-permissions branch from 602f4a5 to 7e45ae0 Compare July 9, 2025 04:51
@adityaramani
Copy link
Contributor

Looks like you need to run make fmt and re-push. Could you also remove the other changes from the RegistryClientTests file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityaramani adityaramani Awaiting requested review from adityaramani

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image push tests permissions in CI
3 participants
@Siddhant-K-code @adityaramani @dcantah