Add filesystem notification (FSNotify) support #294
Conversation
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
f89a058 to
128421e
Compare
realrajaryan
force-pushed
the
users/realrajaryan/fsnotify
branch
from
128421e to
816c698
Compare
| @@ -60,6 +60,8 @@ service SandboxContext { | |||
| rpc Sync(SyncRequest) returns (SyncResponse); | |||
| // Send a signal to a process via the PID. | |||
| rpc Kill(KillRequest) returns (KillResponse); | |||
| // Notify guest of filesystem events from host. | |||
| rpc NotifyFileSystemEvent(NotifyFileSystemEventRequest) returns (NotifyFileSystemEventResponse); | |||
There was a problem hiding this comment.
Wondering if we should have messages for FileSystemEvent and FileSystemEventList, and have the request type deal with lists for performance. We'd need to work out how do deal with errors... perhaps a list of error responses, where each contains a FileSystemEvent, and an error string. An empty response list means no errors.
There was a problem hiding this comment.
A stream is likely the right answer.
|
|
||
| // Test 1: CREATE event | ||
| print("Testing CREATE event...") | ||
| let createResponse = try await agent.notifyFileSystemEvent(path: "/mnt/test/new_file.txt", eventType: .create) |
There was a problem hiding this comment.
Should probably test create event on an existing file.
The reasoning is that from the point of view of your macOS filesystem monitor it will:
- Get an event from macOS that a file was created.
- At this point the file exists and should be accessible to the container (not sure what the latency for this is)
- Trigger a create event for the already-existing file.
| case .modify: | ||
| // Touch file to update timestamp -> generates IN_ATTRIB event | ||
| let now = Date() | ||
| try FileManager.default.setAttributes( |
There was a problem hiding this comment.
We shouldn't change the modification date. The modification date was already changed, we just want to notify.
| ) | ||
|
|
||
| case .create: | ||
| // Use chmod with same permissions to generate IN_ATTRIB event |
There was a problem hiding this comment.
Better to error out if we can't get permissions.
chmodding a file from 400 to 644 wouldn't be ideal, nor would changing a file from 755 to 644.
|
@realrajaryan Can you take a peek at the CI fail, it's for the new test added |
Addresses apple/container#141, where containers don't receive filesystem events on mounted volumes, preventing incremental rebuilds and other file-watching features. This PR implements the guest-side components for FSNotify. Host-side implementation in the container repo will complete the pipeline.
Summary:
cctl fsnotify) and integration test infrastructure