Improvements to Protobuf.Makefile
#356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglogan
reviewed
Oct 27, 2025
| .PHONY: protoc-gen-swift | ||
| protoc-gen-swift: | ||
| swift build --product protoc-gen-swift | ||
| @$(SWIFT) build --product protoc-gen-swift |
There was a problem hiding this comment.
SWIFT has to be defined in the environment or the build fails?
I don't see any default definition.
There was a problem hiding this comment.
Protobuf.Makefile is imported by Makefile, where the variables are defined. Other such variables outside changes in this PR - ROOT_DIR and BUILD_BIN_DIR.
7 tasks
jglogan
approved these changes
Oct 30, 2025
jglogan
pushed a commit
to apple/container
that referenced
this pull request
Oct 30, 2025
- Sync `Protobuf.Makefile` with other projects. - Also see apple/containerization#356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to
Protobuf.Makefile. Also see apple/container#821.