Adds MACAddress type. #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplifies processing and validation of MAC addresses for apple/container#1005, where we need to create MAC addresses and corresponding link local IPv6 addresses. - Adds Codable for IPAddress and CIDR for apple/container#1006, so we can parse and relay IP addresses regardless of address family for port forwards.
7 tasks
dcantah
reviewed
Jan 5, 2026
Comment on lines
35
to
36
| /// - Parameter string: The IPv4 address string in dotted decimal notation (e.g., "192.168.1.1") | ||
| /// - Throws: `IPAddressError.unableToParse` if the string is not a valid IPv4 address |
Contributor
There was a problem hiding this comment.
Doesn't seem to be related to this type
| /// MACAddress.parse("01:23:45:67:89:ab") // Returns: 0x00000123456789ab | ||
| /// MACAddress.parse("01-23-45-67-89-AB") // Returns: 0x00000123456789ab | ||
| /// MACAddress.parse("00:00:00:00:00:00") // Returns: 0x0000000000000000 | ||
| /// MACAddress.parse("ff:ff:ff:ff:ff:ff") // Returns: 0xffffffffffffffff |
Contributor
There was a problem hiding this comment.
This seems like it's not ignoring the top 16 bits
| for byte in utf8 { | ||
| // ASCII whitespace: space(32), tab(9), newline(10), return(13) | ||
| if byte == 32 || byte == 9 || byte == 10 || byte == 13 { | ||
| throw IPAddressError.unableToParse |
Contributor
There was a problem hiding this comment.
Oh maybe my prior comment was only partially wrong, but I would expect we return some MacAddressError instead
Contributor
Author
There was a problem hiding this comment.
I changed IPAddressError to AddressError instead of creating a redundant error type, but I can create a separate MACAddressError for this type if we think it's useful.
dcantah
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.