Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only delay the restart of fdbserver if the process exited with an exit code other than 0 #11802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only delay the restart of fdbserver if the process exited with an exit code other than 0 #11802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion fdbmonitor/fdbmonitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,16 @@ int main(int argc, char** argv) {
int delay = cmd->get_and_update_current_restart_delay();
if (!cmd->quiet) {
if (WIFEXITED(child_status)) {
Severity priority = (WEXITSTATUS(child_status) == 0) ? SevWarn : SevError;
Severity priority;
// If the process exited successfully, e.g. because someone restarted the process
// with fdbcli kill we don't want to delay the restart. We only want to delay
// the restart if the process was exited unsuccessfully (exit code different from 0).
if (WEXITSTATUS(child_status) == 0) {
priority = SevWarn;
delay = 0;
} else {
priority = SevError;
}
log_process_msg(priority,
cmd->ssection.c_str(),
"Process %d exited %d, restarting in %d seconds\n",
Expand Down