database configuration error reporting #12378

dgulinobw · 2025-09-19T15:00:07Z

Problem: fdbcli makes many checks to determine if a configuration change is valid, but if any of those tests fail, it does not give any more information to the user than "ERROR: These changes would make the configuration invalid". This change outputs any failed test and the returning boolean value to allow informed debugging. This is an enhancement, not a bug fix.
Tests: I ran valid and invalid configurations via fileconfigure regions-bad.json and filedconfigure regions-valid.json which returned expected output. This change only impacts administrative use of fdbcli, so should have no performance impact on the database itself.

regions-bad.json:

{
    "regions": [{
        "datacenters": [
            {
                "id": "dc1",
                "priority": 1
            }
        ],
        "datacenters": [
            {
                "id": "dc2",
                "priority": -1
            }
        ]
    }]
}

fdb> fileconfigure regions-bad.json
(usableRegions == 1 || regions.size() == 2): false
ERROR: These changes would make the configuration invalid

regions-valid.json

{
        "regions": [
                {
                        "datacenters": [
                                {
                                        "id": "dc1",
                                        "priority": 1
                                }
                        ]
                },
                {
                        "datacenters": [
                                {
                                        "id": "dc2",
                                        "priority": -1
                                }
                        ]}
        ]
}

fdb> fileconfigure regions-valid.json
Configuration changed

Documentation: The function LOG_TEST(expr) is documented in a comment.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Co-authored-by: aider (vertex_ai/gemini-2.5-pro) <[email protected]>

jzhou77

LGTM

foundationdb-ci · 2025-09-19T17:37:09Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 59e7408
Duration 0:04:25
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T17:37:12Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 59e7408
Duration 0:04:28
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T17:37:13Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 59e7408
Duration 0:04:30
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-09-19T17:37:25Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 59e7408
Duration 0:04:44
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T17:37:32Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 59e7408
Duration 0:04:46
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77

please clang-format the code.

foundationdb-ci · 2025-09-19T18:12:40Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 59e7408
Duration 0:39:57
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T18:33:36Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 664ed29
Duration 0:24:34
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T18:37:21Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 59e7408
Duration 1:04:35
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T18:50:03Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 664ed29
Duration 0:41:02
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T18:56:07Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 664ed29
Duration 0:47:07
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T18:57:56Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 664ed29
Duration 0:48:53
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-19T19:30:14Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 664ed29
Duration 1:21:13
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-09-21T01:45:29Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 664ed29
Duration 0:22:44
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-21T02:03:16Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 664ed29
Duration 0:40:35
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-21T02:04:49Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 664ed29
Duration 0:42:04
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-21T02:09:57Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 664ed29
Duration 0:47:14
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-21T02:13:55Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 664ed29
Duration 0:51:12
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-21T02:29:34Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 664ed29
Duration 1:06:50
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77 · 2025-09-22T18:34:04Z

fdbclient/DatabaseConfiguration.cpp

-	      (regions.size() == 0 || tLogPolicy->info() != "dcid^2 x zoneid^2 x 1") &&
+	auto log_test = [](const char* text, bool val) {
+		if (!val) {
+			fprintf(stderr, "%s: false\n", text);


many ctest failures are due to output in stderr. It seems fdbserver also calls this function and in the context of fdbserver, we don't want to write anything to the stderr unless it's a real problem. For fdbcli, writing to stderr is fine.

Specifically, fdbmonitor considers stderr as Severity="40" events:

>>>>>>>>>>>>>>>>>>>> Contents of /root/cbuild_output/tmp/RDMKwZPrRUgvtZga/log/fdbmonitor.log: Time="1758565723.674179" Severity="10" LogGroup="default" Process="fdbmonitor": Started FoundationDB Process Monitor 7.4 (v7.4.0) Time="1758565723.674372" Severity="10" LogGroup="default" Process="fdbmonitor": Watching conf file /root/cbuild_output/tmp/RDMKwZPrRUgvtZga/etc/foundationdb.conf Time="1758565723.674381" Severity="10" LogGroup="default" Process="fdbmonitor": Watching conf dir /root/cbuild_output/tmp/RDMKwZPrRUgvtZga/etc/ (2) Time="1758565723.674399" Severity="10" LogGroup="default" Process="fdbmonitor": Loading configuration /root/cbuild_output/tmp/RDMKwZPrRUgvtZga/etc/foundationdb.conf Time="1758565723.674496" Severity="10" LogGroup="default" Process="fdbmonitor": Starting fdbserver.60791 Time="1758565723.674733" Severity="10" LogGroup="default" Process="fdbserver.60791": Launching /root/cbuild_output/bin/fdbserver (144481) for fdbserver.60791 Time="1758565723.682948" Severity="10" LogGroup="default" Process="fdbserver.60791": ZoneId set to 0, dcId to [not set] Time="1758565723.706705" Severity="10" LogGroup="default" Process="fdbserver.60791": FDBD joined cluster. Time="1758565724.733660" Severity="40" LogGroup="default" Process="fdbserver.60791": initialized: false Time="1758565726.681194" Severity="40" LogGroup="default" Process="fdbserver.60791": initialized: false Time="1758565729.664410" Severity="20" LogGroup="default" Process="fdbserver.60791": Process 144481 exited 0, restarting in 0 seconds Time="1758565729.664723" Severity="10" LogGroup="default" Process="fdbserver.60791": Launching /root/cbuild_output/bin/fdbserver (144525) for fdbserver.60791 Time="1758565729.672800" Severity="10" LogGroup="default" Process="fdbserver.60791": ZoneId set to 0, dcId to [not set] Time="1758565729.690314" Severity="10" LogGroup="default" Process="fdbserver.60791": FDBD joined cluster.

dgulinobw · 2025-09-23T13:35:41Z

Should I update this to write to stdout?

…

On Mon, Sep 22, 2025 at 2:34 PM Jingyu Zhou ***@***.***> wrote: EXTERNAL EMAIL Secured by Check Point <https://www.checkpoint.com/harmony/email-security/email-office?friew> ***@***.**** commented on this pull request. ------------------------------ In fdbclient/DatabaseConfiguration.cpp <#12378 (comment)>: > - if (!(initialized && tLogWriteAntiQuorum >= 0 && tLogWriteAntiQuorum <= tLogReplicationFactor / 2 && - tLogReplicationFactor >= 1 && storageTeamSize >= 1 && getDesiredCommitProxies() >= 1 && - getDesiredGrvProxies() >= 1 && getDesiredLogs() >= 1 && getDesiredResolvers() >= 1 && - tLogVersion != TLogVersion::UNSET && tLogVersion >= TLogVersion::MIN_RECRUITABLE && - tLogVersion <= TLogVersion::MAX_SUPPORTED && tLogDataStoreType != KeyValueStoreType::END && - tLogSpillType != TLogSpillType::UNSET && - !(tLogSpillType == TLogSpillType::REFERENCE && tLogVersion < TLogVersion::V3) && - storageServerStoreType != KeyValueStoreType::END && autoCommitProxyCount >= 1 && autoGrvProxyCount >= 1 && - autoResolverCount >= 1 && autoDesiredTLogCount >= 1 && storagePolicy && tLogPolicy && - getDesiredRemoteLogs() >= 1 && remoteTLogReplicationFactor >= 0 && repopulateRegionAntiQuorum >= 0 && - repopulateRegionAntiQuorum <= 1 && usableRegions >= 1 && usableRegions <= 2 && regions.size() <= 2 && - (usableRegions == 1 || regions.size() == 2) && (regions.size() == 0 || regions[0].priority >= 0) && - (regions.size() == 0 || tLogPolicy->info() != "dcid^2 x zoneid^2 x 1") && + auto log_test = [](const char* text, bool val) { + if (!val) { + fprintf(stderr, "%s: false\n", text); many ctest failures are due to output in stderr. It seems fdbserver also calls this function and in the context of fdbserver, we don't want to write anything to the stderr unless it's a real problem. For fdbcli, writing to stderr is fine. — Reply to this email directly, view it on GitHub <#12378 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKQYR4O4WG24PBLXRHKS2L3UA6LDAVCNFSM6AAAAACG7IOMBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJUGUZTCMBWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

jzhou77 · 2025-09-23T21:54:50Z

Should I update this to write to stdout?

I think we should keep writing to stderr, but don't write for fdbserver. There are a couple of solutions to control printing:

use an environment variable
use a knob

I.e., when the variable/knob is set, printing to stderr. Otherwise, don't print. So by default, we don't print for fdbserver. For fdbcli, the printing can be enabled. I think using a knob is probably better.

…_test output

Co-authored-by: aider (vertex_ai/gemini-2.5-pro) <[email protected]>

jzhou77

The output to stderr needs to be changed such that fdbserver won't by default print the message.

…of database configuration test failures in fdbcli

jzhou77

Thanks!
LGTM

foundationdb-ci · 2025-09-25T21:59:40Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: ff70bad
Duration 0:04:23
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T21:59:43Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: ff70bad
Duration 0:04:26
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T21:59:47Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: ff70bad
Duration 0:04:27
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T21:59:48Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: ff70bad
Duration 0:04:30
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2025-09-25T21:59:49Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: ff70bad
Duration 0:04:28
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T22:37:31Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: ff70bad
Duration 0:42:12
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T23:01:41Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: ff70bad
Duration 1:06:20
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T23:25:20Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 5b64318
Duration 0:26:02
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T23:39:29Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 5b64318
Duration 0:40:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-25T23:48:06Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 5b64318
Duration 0:48:48
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-26T00:03:33Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 5b64318
Duration 1:04:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-26T00:04:43Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 5b64318
Duration 1:05:25
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2025-09-26T00:13:53Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 5b64318
Duration 1:14:32
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

dgulinobw and others added 3 commits September 18, 2025 14:41

refactor: Improve DatabaseConfiguration::isValid() debuggability

1d1da09

Refactor: Only log log_test failures to stderr

e50277e

Co-authored-by: aider (vertex_ai/gemini-2.5-pro) <[email protected]>

added comments to document

59e7408

jzhou77 approved these changes Sep 19, 2025

View reviewed changes

jzhou77 closed this Sep 19, 2025

jzhou77 reopened this Sep 19, 2025

jzhou77 reviewed Sep 19, 2025

View reviewed changes

ran clang-format DatabaseConfiguration.cpp

664ed29

jzhou77 closed this Sep 19, 2025

jzhou77 reopened this Sep 19, 2025

jzhou77 closed this Sep 21, 2025

jzhou77 reopened this Sep 21, 2025

jzhou77 reviewed Sep 22, 2025

View reviewed changes

dgulinobw and others added 5 commits September 23, 2025 18:06

docs: Clarify fprint call condition in isValid()

9a34618

refactor: Add boolean parameter to isValid to conditionally print log…

2f74f1f

…_test output

Refactor: Add print_invalid param to DatabaseConfiguration::isValid

a8008de

Co-authored-by: aider (vertex_ai/gemini-2.5-pro) <[email protected]>

chore: Add comment about print_invalid parameter

2046c43

chore: Remove fulfilled AI instruction comment

d148da6

Co-authored-by: aider (vertex_ai/gemini-2.5-pro) <[email protected]>

jzhou77 requested changes Sep 25, 2025

View reviewed changes

added client knob cli_print_invalid_configuration to enable printing …

ff70bad

…of database configuration test failures in fdbcli

jzhou77 approved these changes Sep 25, 2025

View reviewed changes

jzhou77 closed this Sep 25, 2025

jzhou77 reopened this Sep 25, 2025

ran clang-format

5b64318

jzhou77 closed this Sep 25, 2025

jzhou77 reopened this Sep 25, 2025

jzhou77 merged commit e130005 into apple:main Sep 26, 2025
6 checks passed

database configuration error reporting #12378

database configuration error reporting #12378

Conversation

dgulinobw commented Sep 19, 2025

Code-Reviewer Section

For Release-Branches

Uh oh!

jzhou77 left a comment

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

jzhou77 left a comment

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Sep 19, 2025

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented Sep 21, 2025

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

jzhou77 Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgulinobw commented Sep 23, 2025 via email

Uh oh!

jzhou77 commented Sep 23, 2025

Uh oh!

jzhou77 left a comment

Choose a reason for hiding this comment

Uh oh!

jzhou77 left a comment

Choose a reason for hiding this comment

jzhou77 Sep 22, 2025 •

edited

Loading