Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically run CI builds for external contributions #152

Open
odenix opened this issue Feb 14, 2024 · 4 comments · May be fixed by #885
Open

Automatically run CI builds for external contributions #152

odenix opened this issue Feb 14, 2024 · 4 comments · May be fixed by #885

Comments

@odenix
Copy link
Contributor

odenix commented Feb 14, 2024 •
edited
Loading

When an external contributor submits a PR, CI builds are on hold until manually authorized by a team member. This complicates external contributions as we won't know the build outcome for a long time. Is there a way to alleviate this pain?

PS: Out of curiosity, why did you choose CircleCI over GitHub Actions?
@bioball
Copy link
Contributor

bioball commented Feb 23, 2024

We're working on a process to run CI for high volume contributors.

For CircleCI vs. GitHub Actions: I don't have an answer for you here, unfortunately!

@odenix
Copy link
Contributor Author

odenix commented Oct 19, 2024

Any progress? This is the biggest pain point of contributing to Pkl.

@StefMa
Copy link
Contributor

StefMa commented Nov 21, 2024

For CircleCI vs. GitHub Actions: I don't have an answer for you here, unfortunately!

Would you accept a PR that moves from CircleCI to GitHub Actions? 🤔

@odenix
Copy link
Contributor Author

odenix commented Nov 23, 2024 •
edited
Loading

Would you accept a PR that moves from CircleCI to GitHub Actions?

This would be a significant step forward for contributors, enabling them to

I've noticed that some Apple OSS projects already use GitHub Actions.

@StefMa StefMa linked a pull request Jan 15, 2025 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use GitHub Actions for checks StefMa/pkl
3 participants
@bioball @StefMa @odenix