Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone ✌️
this PR might fix #152 and therefore also contributes to #225.
Two reasons why this would be a step forward:
I just converted the
checks
from the circleci config for now becauseLe me know if this is "fine" or if I also convert all the other jobs.
On the other side we can also do this as follow-ups in other PRs.
Let me know what you prefer.
Because using a matrix is super easy to setup on actions, I also decided to run jdk 21 on windows 🤷
This isn't in the circleci config but doesn't hurt i guess?!
If you want to see how this looks like in action, checkout this run on my fork:
TODO before merge: