Vendor org.graalvm.collections #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
Package org.graalvm.collections is used throughout the Pkl codebase.
It is most heavily used in the Truffle interpreter,
which requires putting most collection methods behind @TruffleBoundary.
At the moment, this is done by wrapping collection methods
with static methods declared in classes EconomicMaps and EconomicSets.
However, static wrapper methods are inconvenient to use,
decrease code readability, add some overhead, and are easy to forget about.
Changes:
- vendor package org.graalvm.collections into org.pkl.core.collection
- org.graalvm.collections is licensed under:
The Universal Permissive License (UPL), Version 1.0
- vendored version:
https://github.com/oracle/graal/tree/graal-23.0.3/sdk/src/org.graalvm.collections/src/org/graalvm/collections
- add package-info.java with original license
- annotate most public methods with @TruffleBoundary
- add @nullable annotations
- switching to JSpecify will enable more accurate nullability checks
- remove prefix tree classes (not used in Pkl)
- make no other code changes to simplify review/updates
- inline and remove EconomicMaps/Sets wrapper methods
- replace usages of EconomicMaps.equals/hashCode with EconomicMapUtil.equals/hashCode
- fix ProjectDeps.hashCode()
Result:
Cleaner, safer, and more efficient code.
translatenix
force-pushed
the
vendor-collections
branch
from
a5f3237
to
7a12edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Package org.graalvm.collections is used throughout the Pkl codebase. It is most heavily used in the Truffle interpreter, which requires putting most collection methods behind @TruffleBoundary. At the moment, this is done by wrapping collection methods with static methods declared in classes EconomicMaps and EconomicSets. However, static wrapper methods are inconvenient to use, decrease code readability, add some overhead, and are easy to forget about.
Changes:
@TruffleBoundary@NullableannotationsResult:
Cleaner, safer, and more efficient code.