Minor API revisions #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means that the `seek(toRelativeOffset:)` and `seek(toOffsetFromEnd:)` are restricted to movement _within_ the current range of the span. This is how these are used, and is a bit easier to explain because movement is therefore bound by both ends of the span. The `seek(toAbsoluteOffset:)` method still works with the original, un-shrunken bounds, so has a different set of semantics (and may benefit from a different name).
This API is the mirror image of the Collection subscript that is also provided, and is the less natural way to spell the operation.
These should be consistent with the element-based subscripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParserRange.slicing(_:)APIEndianness.isLittleEndianBooleanseek(toRelativeOffset:)andseek(toOffsetFromEnd:)to current bounds of spanChecklist