Skip to content

Add parsers for InlineArray #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Add parsers for InlineArray #35

merged 1 commit into from
Sep 19, 2025

Conversation

@natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Sep 10, 2025

This adds two parsers that produces inline arrays:

  • a byte-based parser that fills an InlineArray with UInt8 values
  • a parser closure-based parser that fills an InlineArray with the results of the parser, called the required number of times.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've run Scripts/format.sh to correctly format my change
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Add parsers for InlineArray
f693ba8 
This adds two parsers that produces inline arrays:
- a byte-based parser that fills an InlineArray with `UInt8` values
- a parser closure-based parser that fills an InlineArray with
  the results of the parser, called the required number of times.
@natecook1000 natecook1000 marked this pull request as ready for review September 10, 2025 18:53
numist
numist approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@numist numist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should make parsing fixed size byte fields (like magic bytes) a lot easier.

@natecook1000 natecook1000 merged commit 9056f2c into main Sep 19, 2025
16 checks passed
@natecook1000 natecook1000 deleted the inline-array branch September 19, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@numist numist numist approved these changes

@stephentyrone stephentyrone Awaiting requested review from stephentyrone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natecook1000 @numist