[CI] Add CI flags to verify all public types are explicitly Sendable or not Sendable. #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's important that every public type has been explicitly considered to be or not be Sendable, and we should reflect it in the type system.
The
-Xfrontend -require-explicit-sendableflags allow emitting a warning when this is missed.Modifications
Added the flags to be included whenever we're building all traits using the env var, basically means in CI and optionally locally during development.
Result
Will surface any time when a new public type is added without an explicit Sendable/not Sendable annotation.
Test Plan
Ran locally, tried adding a dummy implicitly not Sendable type, saw the warning.