Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+eventStream introduce a better, more debuggable way to use eventStream #1078

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Oct 27, 2022

Improve debug information from subscribing to event stream.

Aiming to debug why on CI this sometimes lost an event: ClusterSingletonPluginClusteredTests.test_singleton_lifecycle

@ktoso
Copy link
Member Author

ktoso commented Oct 27, 2022

This results in such improved information about stream subscribers:

[captured] [first] [2022-10-27 14:19:08.3220] [ClusterEventStream.swift:240][/system/clusterEventStream] [trace] Published event membershipChange(sact://[email protected]:7111 :: [unknown] -> [joining]) to 4 subscribers and 3 async subscribers
[captured] [first] // "actor/id": /system/clusterEventStream
[captured] [first] // "eventStream/asyncSubscribers":
[captured] [first] //   SubscriberID(oid: ObjectIdentifier(0x0000600000604240), loc: DistributedCluster/OperationLogDistributedReceptionist.swift:260)
[captured] [first] //   SubscriberID(oid: ObjectIdentifier(0x000060000061bd80), loc: DistributedCluster/DowningStrategy.swift:98)
[captured] [first] //   SubscriberID(oid: ObjectIdentifier(0x000060000061bd60), loc: DistributedCluster/ClusterSingletonBoss.swift:94)
[captured] [first] // "eventStream/event": DistributedCluster.Cluster.Event.membershipChange(sact://[email protected]:7111 :: [unknown] -> [joining])

Heh of course now it passed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants