Skip to content

Conversation

@fboemer
Copy link
Contributor

@fboemer fboemer commented Dec 8, 2025

Make EncryptionParametersConfig, PirDatabaseConfig, PnnsDatabaseConfig Sendable, so that we can omit nonisolated(unsafe) when creating custom benchmark configs.

E.g. we can now omit ``nonisolated(unsafe)` from the below:

nonisolated(unsafe) let encryptionConfig = EncryptionParametersConfig(
    polyDegree: 4096,
    plaintextModulusBits: [5],
    coefficientModulusBits: [27, 28, 28])

@fboemer fboemer requested a review from hamishun December 8, 2025 19:33
Copy link
Contributor

@karulont karulont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably other things that should be Sendable.

@fboemer fboemer marked this pull request as ready for review December 8, 2025 19:53
@fboemer fboemer requested a review from RuiyuZhu as a code owner December 8, 2025 19:53
@fboemer fboemer merged commit da2e56e into main Dec 8, 2025
26 checks passed
@fboemer fboemer deleted the fboemer/benchmark-utils branch December 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants