Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@_implementationOnly also for Swift 5.3 #212

Merged
merged 2 commits into from
May 1, 2020
Merged

@_implementationOnly also for Swift 5.3 #212

merged 2 commits into from
May 1, 2020

Conversation

weissi
Copy link
Member

@weissi weissi commented Apr 29, 2020

Motivation:

@_implementationOnly also works in Swift 5.3, let's use it.

Modification:

Use @_implementationOnly for Swift 5.1 ... 5.3

Result:

Proper 5.3 support.

@weissi
@_implementationOnly also for Swift 5.3
ced674f 
Motivation:

@_implementationOnly also works in Swift 5.3, let's use it.

Modification:

Use @_implementationOnly for Swift 5.1 ... 5.3

Result:

Proper 5.3 support.
@weissi weissi requested a review from Lukasa April 29, 2020 20:07
@Lukasa
Copy link
Contributor

Lukasa commented Apr 30, 2020

@swift-nio-bot test this please

@weissi
Copy link
Member Author

weissi commented Apr 30, 2020

hit #197

@weissi
Copy link
Member Author

weissi commented Apr 30, 2020

5.2 is a red herring:

07:08:12 .FileNotFoundError: [Errno 2] No such file or directory: './docker/docker-compose.1804.52.yaml'

@weissi
Copy link
Member Author

weissi commented Apr 30, 2020

@swift-nio-bot test this please

@weissi
Copy link
Member Author

weissi commented Apr 30, 2020

hit #210

@weissi
Copy link
Member Author

weissi commented Apr 30, 2020

@swift-nio-bot test this please

@Lukasa Lukasa added the semver/patch No public API change. label May 1, 2020
@Lukasa Lukasa added this to the 2.8.0 milestone May 1, 2020
@Lukasa
Copy link
Contributor

Lukasa commented May 1, 2020

And lo, the flaky tests have been resolved.

@Lukasa Lukasa merged commit e0049a1 into apple:master May 1, 2020
@Lukasa Lukasa modified the milestones: 2.8.0, 2.7.2 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/patch No public API change.
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@weissi @Lukasa