Disable warnings as errors on Swift 6 and main (#2793)

Motivation: The Swift 6 compiler emits a number of warnings about sendability which we haven't dealt with yet. The CI failing on warnings may mask other compilation issues or test failures. Modifications: - Disable warnings as errors on Swift 6 and main Result: Swift 6 and main CI should pass
apple · Jul 18, 2024 · 980bd3e · 980bd3e
1 parent 7948ed2
commit 980bd3e
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 62 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -2,8 +2,8 @@ name: Pull Request
 
 on:
   pull_request:
-    types: [opened, reopened, synchronize, ready_for_review]
- 
+    types: [opened, reopened, synchronize]
+
 jobs:
   call-pull-request-soundness-workflow:
     name: Soundness
@@ -18,6 +18,9 @@ jobs:
     with:
       name: "Unit tests"
       matrix_linux_command: "swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
+      # Disable warnings as errors: Swift 6 emits sendability warnings that haven't been dealt with yet.
+      matrix_linux_nightly_main_command_override: "swift test --explicit-target-dependency-import-check error"
+      matrix_linux_nightly_6_0_command_override: "swift test --explicit-target-dependency-import-check error"
 
   call-pull-request-benchmark-workflow:
     name: Benchmarks

diff --git a/IntegrationTests/tests_04_performance/Thresholds/nightly-6.0.json b/IntegrationTests/tests_04_performance/Thresholds/nightly-6.0.json
@@ -1,8 +1,8 @@
 {
-    "10000000_asyncsequenceproducer": 21,
+    "10000000_asyncsequenceproducer": 19,
     "1000000_asyncwriter": 1000050,
-    "1000_addHandlers": 45050,
-    "1000_addHandlers_sync": 38050,
+    "1000_addHandlers": 44050,
+    "1000_addHandlers_sync": 37050,
     "1000_addRemoveHandlers_handlercontext": 8050,
     "1000_addRemoveHandlers_handlername": 8050,
     "1000_addRemoveHandlers_handlertype": 8050,
@@ -11,15 +11,15 @@
     "1000_copying_bytebufferview_to_array": 1050,
     "1000_copying_circularbuffer_to_array": 1050,
     "1000_getHandlers": 8050,
-    "1000_getHandlers_sync": 36,
+    "1000_getHandlers_sync": 35,
     "1000_reqs_1_conn": 26400,
-    "1000_rst_connections": 147000,
+    "1000_rst_connections": 145050,
     "1000_tcpbootstraps": 3050,
-    "1000_tcpconnections": 155050,
+    "1000_tcpconnections": 152050,
     "1000_udp_reqs": 6050,
     "1000_udpbootstraps": 2050,
-    "1000_udpconnections": 76050,
-    "1_reqs_1000_conn": 393000,
+    "1000_udpconnections": 75050,
+    "1_reqs_1000_conn": 389050,
     "bytebuffer_lots_of_rw": 2050,
     "creating_10000_headers": 0,
     "decode_1000_ws_frames": 2050,
@@ -42,10 +42,9 @@
     "modifying_byte_buffer_view": 6050,
     "ping_pong_1000_reqs_1_conn": 343,
     "read_10000_chunks_from_file": 110200,
-    "schedule_10000_tasks": 50100,
+    "schedule_10000_tasks": 40100,
     "schedule_and_run_10000_tasks": 50050,
     "scheduling_10000_executions": 89,
     "udp_1000_reqs_1_conn": 6200,
-    "udp_1_reqs_1000_conn": 165050
-  }
-
+    "udp_1_reqs_1000_conn": 162050
+}
diff --git a/IntegrationTests/tests_04_performance/Thresholds/nightly-main.json b/IntegrationTests/tests_04_performance/Thresholds/nightly-main.json
@@ -1,50 +1,50 @@
 {
-  "10000000_asyncsequenceproducer": 21,
-  "1000000_asyncwriter": 1000050,
-  "1000_addHandlers": 45050,
-  "1000_addHandlers_sync": 38050,
-  "1000_addRemoveHandlers_handlercontext": 8050,
-  "1000_addRemoveHandlers_handlername": 8050,
-  "1000_addRemoveHandlers_handlertype": 8050,
-  "1000_autoReadGetAndSet": 18050,
-  "1000_autoReadGetAndSet_sync": 0,
-  "1000_copying_bytebufferview_to_array": 1050,
-  "1000_copying_circularbuffer_to_array": 1050,
-  "1000_getHandlers": 8050,
-  "1000_getHandlers_sync": 36,
-  "1000_reqs_1_conn": 26400,
-  "1000_rst_connections": 147000,
-  "1000_tcpbootstraps": 3050,
-  "1000_tcpconnections": 155050,
-  "1000_udp_reqs": 6050,
-  "1000_udpbootstraps": 2050,
-  "1000_udpconnections": 76050,
-  "1_reqs_1000_conn": 393000,
-  "bytebuffer_lots_of_rw": 2050,
-  "creating_10000_headers": 0,
-  "decode_1000_ws_frames": 2050,
-  "encode_1000_ws_frames_holding_buffer": 3,
-  "encode_1000_ws_frames_holding_buffer_with_mask": 2050,
-  "encode_1000_ws_frames_holding_buffer_with_space": 3,
-  "encode_1000_ws_frames_holding_buffer_with_space_with_mask": 2050,
-  "encode_1000_ws_frames_new_buffer": 3050,
-  "encode_1000_ws_frames_new_buffer_with_mask": 5050,
-  "encode_1000_ws_frames_new_buffer_with_space": 3050,
-  "encode_1000_ws_frames_new_buffer_with_space_with_mask": 5050,
-  "execute_hop_10000_tasks": 0,
-  "future_erase_result": 4050,
-  "future_lots_of_callbacks": 53050,
-  "get_100000_headers_canonical_form": 700050,
-  "get_100000_headers_canonical_form_trimming_whitespace": 700050,
-  "get_100000_headers_canonical_form_trimming_whitespace_from_long_string": 700050,
-  "get_100000_headers_canonical_form_trimming_whitespace_from_short_string": 700050,
-  "modifying_1000_circular_buffer_elements": 0,
-  "modifying_byte_buffer_view": 6050,
-  "ping_pong_1000_reqs_1_conn": 343,
-  "read_10000_chunks_from_file": 110200,
-  "schedule_10000_tasks": 50100,
-  "schedule_and_run_10000_tasks": 50050,
-  "scheduling_10000_executions": 89,
-  "udp_1000_reqs_1_conn": 6200,
-  "udp_1_reqs_1000_conn": 165050
+    "10000000_asyncsequenceproducer": 19,
+    "1000000_asyncwriter": 1000050,
+    "1000_addHandlers": 44050,
+    "1000_addHandlers_sync": 37050,
+    "1000_addRemoveHandlers_handlercontext": 8050,
+    "1000_addRemoveHandlers_handlername": 8050,
+    "1000_addRemoveHandlers_handlertype": 8050,
+    "1000_autoReadGetAndSet": 18050,
+    "1000_autoReadGetAndSet_sync": 0,
+    "1000_copying_bytebufferview_to_array": 1050,
+    "1000_copying_circularbuffer_to_array": 1050,
+    "1000_getHandlers": 8050,
+    "1000_getHandlers_sync": 35,
+    "1000_reqs_1_conn": 26400,
+    "1000_rst_connections": 145050,
+    "1000_tcpbootstraps": 3050,
+    "1000_tcpconnections": 152050,
+    "1000_udp_reqs": 6050,
+    "1000_udpbootstraps": 2050,
+    "1000_udpconnections": 75050,
+    "1_reqs_1000_conn": 389050,
+    "bytebuffer_lots_of_rw": 2050,
+    "creating_10000_headers": 0,
+    "decode_1000_ws_frames": 2050,
+    "encode_1000_ws_frames_holding_buffer": 3,
+    "encode_1000_ws_frames_holding_buffer_with_mask": 2050,
+    "encode_1000_ws_frames_holding_buffer_with_space": 3,
+    "encode_1000_ws_frames_holding_buffer_with_space_with_mask": 2050,
+    "encode_1000_ws_frames_new_buffer": 3050,
+    "encode_1000_ws_frames_new_buffer_with_mask": 5050,
+    "encode_1000_ws_frames_new_buffer_with_space": 3050,
+    "encode_1000_ws_frames_new_buffer_with_space_with_mask": 5050,
+    "execute_hop_10000_tasks": 0,
+    "future_erase_result": 4050,
+    "future_lots_of_callbacks": 53050,
+    "get_100000_headers_canonical_form": 700050,
+    "get_100000_headers_canonical_form_trimming_whitespace": 700050,
+    "get_100000_headers_canonical_form_trimming_whitespace_from_long_string": 700050,
+    "get_100000_headers_canonical_form_trimming_whitespace_from_short_string": 700050,
+    "modifying_1000_circular_buffer_elements": 0,
+    "modifying_byte_buffer_view": 6050,
+    "ping_pong_1000_reqs_1_conn": 343,
+    "read_10000_chunks_from_file": 110200,
+    "schedule_10000_tasks": 40100,
+    "schedule_and_run_10000_tasks": 50050,
+    "scheduling_10000_executions": 89,
+    "udp_1000_reqs_1_conn": 6200,
+    "udp_1_reqs_1000_conn": 162050
 }