-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle bind failures when running NIO in a tight sandbox #2616
Open
dkz2
wants to merge
13
commits into
apple:main
Choose a base branch
from
dkz2:fix-sandbox-bind-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−4
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d269c1c
fixed sandbox bind error
dkz2 cd40dee
Merge branch 'main' into fix-sandbox-bind-error
dkz2 3b33ceb
transition to closed state when bind fails but still hitting assertion
dkz2 7f03ce8
Merge branch 'fix-sandbox-bind-error' of https://github.com/dkz2/swif…
dkz2 e13a5b2
propagate bind up if it fails
dkz2 a4863a8
cleanup
dkz2 5f1d8c4
Merge branch 'apple:main' into fix-sandbox-bind-error
dkz2 f18ea23
Merge branch 'main' of https://github.com/dkz2/swift-nio into fix-san…
dkz2 85bfd59
fold assertBindFailure
dkz2 6d777bf
Merge branch 'fix-sandbox-bind-error' of https://github.com/dkz2/swif…
dkz2 57266e9
removed unneeded file
dkz2 ee340f1
Merge branch 'main' of https://github.com/dkz2/swift-nio into fix-san…
dkz2 1e9b010
update branch
dkz2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon bind failing, the
lifecycleManager
seems to remain in thepreRegistered
state. thus we are transiting to theclosed
state here.