Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dn loop bound box benchmark #2778

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Dn loop bound box benchmark #2778

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
33e3a55
Add NIOLoopBoundBox benchmark
dnadoba Jul 10, 2024
3842f7c
run `./dev/update-benchmark-thresholds.sh`
dnadoba Jul 10, 2024
7927b1f
Merge branch 'main' into dn-loop-bound-box-benchmark
dnadoba Jul 10, 2024
6bc8978
run CI again
dnadoba Jul 10, 2024
90863cb
Merge branch 'dn-loop-bound-box-benchmark' of github.com:dnadoba/swif…
dnadoba Jul 10, 2024
a87b349
Merge branch 'main' into dn-loop-bound-box-benchmark
dnadoba Jul 11, 2024
05ab847
Update benchmark loop
dnadoba Jul 11, 2024
d14d7a9
Fix benchmark thresholds update script
FranzBusch Jul 11, 2024
014e903
Merge branch 'fb-benchmark-update-thresholds' into dn-loop-bound-box-…
dnadoba Jul 12, 2024
1dd1710
run `./dev/update-benchmark-thresholds.sh`
dnadoba Jul 12, 2024
e9b71b7
Remove inner loop
dnadoba Jul 15, 2024
4b4181b
Merge branch 'main' into dn-loop-bound-box-benchmark
dnadoba Jul 15, 2024
b25527a
run ./dev/update-benchmark-thresholds.sh
dnadoba Jul 15, 2024
986dc2e
run ./dev/update-benchmark-thresholds.sh again
dnadoba Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Benchmarks/Benchmarks/NIOCoreBenchmarks/Benchmarks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,11 @@ let benchmarks = {
blackHole(asyncChanel)
}
}

Benchmark(
"NIOLoopBoundBox.value",
configuration: .init(metrics: defaultMetrics)
) { _ in
runNIOLoopBoundBoxInPlaceMutation()
}
}
29 changes: 29 additions & 0 deletions Benchmarks/Benchmarks/NIOCoreBenchmarks/NIOLoopBoundBox.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//===----------------------------------------------------------------------===//
//
// This source file is part of the SwiftNIO open source project
//
// Copyright (c) 2024 Apple Inc. and the SwiftNIO project authors
// Licensed under Apache License v2.0
//
// See LICENSE.txt for license information
// See CONTRIBUTORS.txt for the list of SwiftNIO project authors
//
// SPDX-License-Identifier: Apache-2.0
//
//===----------------------------------------------------------------------===//

import NIOCore
import NIOEmbedded

func runNIOLoopBoundBoxInPlaceMutation() {
let embeddedEventLoop = EmbeddedEventLoop()
let boundBox = NIOLoopBoundBox([Int](), eventLoop: embeddedEventLoop)
boundBox.value.reserveCapacity(1000)

for i in 0..<1000 {
boundBox.value.append(i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run this multiple times, for the scaling factor? Ideally we’d only count allocations in the loop body, as we’re otherwise very sensitive to the runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. This breaks the benchmarking comparison tool as it now thinks we have improved by 0% instead of 100% 😆

$ swift package benchmark baseline compare v2.68.0 --filter="NIOLoopBoundBox.value"  
[...]
----------------------------------------------------------------------------------------------------------------------------
NIOLoopBoundBox.value metrics
----------------------------------------------------------------------------------------------------------------------------

╒══════════════════════════════════════════╤═════════╤═════════╤═════════╤═════════╤═════════╤═════════╤═════════╤═════════╕
│             Malloc (total) *             │      p0 │     p25 │     p50 │     p75 │     p90 │     p99 │    p100 │ Samples │
╞══════════════════════════════════════════╪═════════╪═════════╪═════════╪═════════╪═════════╪═════════╪═════════╪═════════╡
│                 v2.68.0                  │    1001 │    1001 │    1001 │    1001 │    1001 │    1001 │    1001 │       8 │
├──────────────────────────────────────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┤
│               Current_run                │       0 │       0 │       0 │       0 │       0 │       0 │       0 │     469 │
├──────────────────────────────────────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┤
│                    Δ                     │   -1001 │   -1001 │   -1001 │   -1001 │   -1001 │   -1001 │   -1001 │     461 │
├──────────────────────────────────────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┤
│              Improvement %               │       0 │       0 │       0 │       0 │       0 │       0 │       0 │     461 │
╘══════════════════════════════════════════╧═════════╧═════════╧═════════╧═════════╧═════════╧═════════╧═════════╧═════════╛

@hassila is this a known issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it seems it is normalizing to the slower benchmark instead of the reverse - looks like a plain bug but don't think we've got a case for it - out of office until August so will be a while before I can have a proper look. If you can, file a case would be great - otherwise I'll pick it up when back.

I would suggest using a scaling factor for your bench mark though and pass it on instead to the function - that way you can get normalized numbers per subiteration

}

precondition(boundBox.value.count == 1000)
precondition(boundBox.value.reduce(0, +) == 499500)
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/5.10/NIOCoreBenchmarks.NIOAsyncChannel.init.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 12
}
}
3 changes: 3 additions & 0 deletions Benchmarks/Thresholds/5.10/NIOCoreBenchmarks.NIOLoopBoundBox.value.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mallocCountTotal" : 1
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/5.10/NIOPosixBenchmarks.TCPEcho.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 108
}
"mallocCountTotal" : 90
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/5.10/NIOPosixBenchmarks.TCPEchoAsyncChannel.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 165000
}
"mallocCountTotal" : 164212
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/5.8/NIOCoreBenchmarks.NIOAsyncChannel.init.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 12
}
}
3 changes: 3 additions & 0 deletions Benchmarks/Thresholds/5.8/NIOCoreBenchmarks.NIOLoopBoundBox.value.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mallocCountTotal" : 2
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/5.8/NIOPosixBenchmarks.TCPEcho.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 110
}
"mallocCountTotal" : 92
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/5.9/NIOCoreBenchmarks.NIOAsyncChannel.init.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 12
}
}
3 changes: 3 additions & 0 deletions Benchmarks/Thresholds/5.9/NIOCoreBenchmarks.NIOLoopBoundBox.value.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mallocCountTotal" : 2
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/5.9/NIOPosixBenchmarks.TCPEcho.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 110
}
"mallocCountTotal" : 92
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/5.9/NIOPosixBenchmarks.TCPEchoAsyncChannel.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 164000
}
"mallocCountTotal" : 164222
}
2 changes: 1 addition & 1 deletion Benchmarks/Thresholds/main/NIOCoreBenchmarks.NIOAsyncChannel.init.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 12
}
}
3 changes: 3 additions & 0 deletions Benchmarks/Thresholds/main/NIOCoreBenchmarks.NIOLoopBoundBox.value.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"mallocCountTotal" : 1
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/main/NIOPosixBenchmarks.TCPEcho.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 108
}
"mallocCountTotal" : 90
}
4 changes: 2 additions & 2 deletions Benchmarks/Thresholds/main/NIOPosixBenchmarks.TCPEchoAsyncChannel.p90.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"mallocCountTotal" : 165000
}
"mallocCountTotal" : 164104
}
2 changes: 1 addition & 1 deletion dev/update-benchmark-thresholds.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ set -o pipefail
here="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
target_repo=${2-"$here/.."}

for f in 57 58 59 510 -nightly; do
for f in 58 59 510 -nightly; do
echo "swift$f"

docker_file=$(if [[ "$f" == "-nightly" ]]; then f=main; fi && ls "$target_repo/docker/docker-compose."*"$f"*".yaml")
Expand Down