-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable warnings as errors on Swift 6 and main #2793
Merged
glbrntt
merged 8 commits into
apple:main
from
glbrntt:disable-warnings-as-errors-on-swift-6
Jul 18, 2024
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
15f5953
Disable warnings as errors on Swift 6 and main
glbrntt cfe294c
Merge branch 'main' into disable-warnings-as-errors-on-swift-6
glbrntt c69c021
Dont rerun CI when marked as ready for review
glbrntt 82fdc03
Update limits
glbrntt 4d7e4e1
add some slack
glbrntt 1b1bda8
more fixes
glbrntt a7e5ef8
fixup
glbrntt 0af2d1c
Merge branch 'main' into disable-warnings-as-errors-on-swift-6
glbrntt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 50 additions & 49 deletions
99
IntegrationTests/tests_04_performance/Thresholds/nightly-main.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,51 @@ | ||
| { | ||
| "10000000_asyncsequenceproducer": 21, | ||
| "1000000_asyncwriter": 1000050, | ||
| "1000_addHandlers": 45050, | ||
| "1000_addHandlers_sync": 38050, | ||
| "1000_addRemoveHandlers_handlercontext": 8050, | ||
| "1000_addRemoveHandlers_handlername": 8050, | ||
| "1000_addRemoveHandlers_handlertype": 8050, | ||
| "1000_autoReadGetAndSet": 18050, | ||
| "1000_autoReadGetAndSet_sync": 0, | ||
| "1000_copying_bytebufferview_to_array": 1050, | ||
| "1000_copying_circularbuffer_to_array": 1050, | ||
| "1000_getHandlers": 8050, | ||
| "1000_getHandlers_sync": 36, | ||
| "1000_reqs_1_conn": 26400, | ||
| "1000_rst_connections": 147000, | ||
| "1000_tcpbootstraps": 3050, | ||
| "1000_tcpconnections": 155050, | ||
| "1000_udp_reqs": 6050, | ||
| "1000_udpbootstraps": 2050, | ||
| "1000_udpconnections": 76050, | ||
| "1_reqs_1000_conn": 393000, | ||
| "bytebuffer_lots_of_rw": 2050, | ||
| "creating_10000_headers": 0, | ||
| "decode_1000_ws_frames": 2050, | ||
| "encode_1000_ws_frames_holding_buffer": 3, | ||
| "encode_1000_ws_frames_holding_buffer_with_mask": 2050, | ||
| "encode_1000_ws_frames_holding_buffer_with_space": 3, | ||
| "encode_1000_ws_frames_holding_buffer_with_space_with_mask": 2050, | ||
| "encode_1000_ws_frames_new_buffer": 3050, | ||
| "encode_1000_ws_frames_new_buffer_with_mask": 5050, | ||
| "encode_1000_ws_frames_new_buffer_with_space": 3050, | ||
| "encode_1000_ws_frames_new_buffer_with_space_with_mask": 5050, | ||
| "execute_hop_10000_tasks": 0, | ||
| "future_erase_result": 4050, | ||
| "future_lots_of_callbacks": 53050, | ||
| "get_100000_headers_canonical_form": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace_from_long_string": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace_from_short_string": 700050, | ||
| "modifying_1000_circular_buffer_elements": 0, | ||
| "modifying_byte_buffer_view": 6050, | ||
| "ping_pong_1000_reqs_1_conn": 343, | ||
| "read_10000_chunks_from_file": 110200, | ||
| "schedule_10000_tasks": 50100, | ||
| "schedule_and_run_10000_tasks": 50050, | ||
| "scheduling_10000_executions": 89, | ||
| "udp_1000_reqs_1_conn": 6200, | ||
| "udp_1_reqs_1000_conn": 165050 | ||
| } | ||
| "10000000_asyncsequenceproducer": 19, | ||
| "1000000_asyncwriter": 1000050, | ||
| "1000_addHandlers": 44050, | ||
| "1000_addHandlers_sync": 37050, | ||
| "1000_addRemoveHandlers_handlercontext": 8050, | ||
| "1000_addRemoveHandlers_handlername": 8050, | ||
| "1000_addRemoveHandlers_handlertype": 8050, | ||
| "1000_autoReadGetAndSet": 18050, | ||
| "1000_autoReadGetAndSet_sync": 0, | ||
| "1000_copying_bytebufferview_to_array": 1050, | ||
| "1000_copying_circularbuffer_to_array": 1050, | ||
| "1000_getHandlers": 8050, | ||
| "1000_getHandlers_sync": 35, | ||
| "1000_reqs_1_conn": 26400, | ||
| "1000_rst_connections": 145000, | ||
| "1000_tcpbootstraps": 3050, | ||
| "1000_tcpconnections": 152050, | ||
| "1000_udp_reqs": 6050, | ||
| "1000_udpbootstraps": 2050, | ||
| "1000_udpconnections": 75050, | ||
| "1_reqs_1000_conn": 389050, | ||
| "bytebuffer_lots_of_rw": 2050, | ||
| "creating_10000_headers": 0, | ||
| "decode_1000_ws_frames": 2050, | ||
| "encode_1000_ws_frames_holding_buffer": 3, | ||
| "encode_1000_ws_frames_holding_buffer_with_mask": 2050, | ||
| "encode_1000_ws_frames_holding_buffer_with_space": 3, | ||
| "encode_1000_ws_frames_holding_buffer_with_space_with_mask": 2050, | ||
| "encode_1000_ws_frames_new_buffer": 3050, | ||
| "encode_1000_ws_frames_new_buffer_with_mask": 5050, | ||
| "encode_1000_ws_frames_new_buffer_with_space": 3050, | ||
| "encode_1000_ws_frames_new_buffer_with_space_with_mask": 5050, | ||
| "execute_hop_10000_tasks": 0, | ||
| "future_erase_result": 4050, | ||
| "future_lots_of_callbacks": 53050, | ||
| "get_100000_headers_canonical_form": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace_from_long_string": 700050, | ||
| "get_100000_headers_canonical_form_trimming_whitespace_from_short_string": 700050, | ||
| "modifying_1000_circular_buffer_elements": 0, | ||
| "modifying_byte_buffer_view": 6050, | ||
| "ping_pong_1000_reqs_1_conn": 343, | ||
| "read_10000_chunks_from_file": 110200, | ||
| "schedule_10000_tasks": 50100, | ||
| "schedule_and_run_10000_tasks": 50050, | ||
| "scheduling_10000_executions": 89, | ||
| "udp_1000_reqs_1_conn": 6200, | ||
| "udp_1_reqs_1000_conn": 165050 | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will prevent running tests when a PR changes status from
drafttoready_for_reviewI think.Unless
synchronizealready covers that, which I don't think so.Currently the tests won't be run if the PR is a
draft.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MahdiBM they do run for draft PRs: #2798
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm that was not my experience with Vapor's CI which has this exact same setting.
I might have gotten something wrong then.
Thanks for confirming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "opened" covers it. Draft / Ready for Review seems orthogonal to whether the PR is open or closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe then the case where it won't work is when you open the PR as draft, then when the CI is over, you add a commit, then after that commit, you mark the PR as
ready_for_review.maybe, not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked and that also works (presumably 'synchronize').