Fix flaky test: testInstantTCPConnectionResetThrowsError #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, hold up. This didn't actually make it go away, just a lot more rare. Used to fail ~1:100, now it's ~1:3000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Running this test in a loop will fail. It's understandable because the test itself is trying to trigger a race condition. We wouldn't see this on our PR CI because it only runs on Darwin.
Modifications:
Extend the test server used in the test with another promise that allows the test to wait for the channel to become active before continuing with the rest of the test.
Result:
Can now run this test repeatedly without failure.