Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import FoundationEssentials in NIOFoundationCompat #2860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Import FoundationEssentials in NIOFoundationCompat #2860

wants to merge 2 commits into from
+18 −3

Conversation

fabianfett
Copy link
Member

Import FoundationEssentials in NIOFoundationCompat, when possible.

Motivation:

In NIOFoundationCompat we only use symbols that are part of the reduced FoundationEssentials module. To reduce binary size, we should only import FoundationEssentials.

Modifications:

  • Add canImport(FoundationEssentials) dance.

Result:

Hopefully smaller binary sizes.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Sep 2, 2024
Lukasa
Lukasa requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't think we can do this without API impact, as our transitive import is still visible to our dependents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @Lukasa