Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fastRebase implementation #3014

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

clintonpi
Copy link
Contributor

Motivation:

UnsafeRawBufferPointer.init(fastRebase:) and UnsafeMutableRawBufferPointer.init(fastRebase:) were shimmed into NIO in #1696. The shim is no longer necessary.

Modifications:

  • Revert the use of the fastRebase inits to the native .init(rebasing:).

Result:

Use of native APIs instead.

Motivation:

UnsafeRawBufferPointer.init(fastRebase:) and UnsafeMutableRawBufferPointer.init(fastRebase:) were shimmed into NIO in apple#1696. The shim is no longer necessay.

Modifications:

- Revert the use of the `fastRebase` inits to the native `.init(rebasing:)`.

Result:

Use of native APIs instead.
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Dec 3, 2024
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintonpi

@glbrntt glbrntt enabled auto-merge (squash) December 3, 2024 15:14
@glbrntt glbrntt merged commit 876fbf6 into apple:main Dec 3, 2024
41 of 43 checks passed
@clintonpi clintonpi deleted the fast-rebase-revert branch December 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants