[wasm][1/2] Add reusable WebAssembly workflow #3331
Conversation
kateinoigakukun
changed the title
|
This is potentially superseded by swiftlang/github-workflows#142 |
kateinoigakukun
force-pushed
the
katei/add-reusable-wasm-workflow
branch
from
5e6da08 to
ebb34ad
Compare
|
We still need this separate PR to add a reusable workflow based on swiftlang/github-workflows#142 |
This is not suppressed by it because NIO and all other server repos are not using the workflows provided by the linked repo due to their limited capabilities. |
| swift_flags: --target NIOCore | ||
| swift_nightly_flags: --target NIOCore |
There was a problem hiding this comment.
FYI: Thanks to swiftlang/github-workflows#149, these two lines can be shortened into one line.
| swift_flags: --target NIOCore | |
| swift_nightly_flags: --target NIOCore | |
| wasm_sdk_build_command: swift build --target NIOCore |
There was a problem hiding this comment.
IIRC swift_nightly_flags in absence of a defined value is auto-populated from swift_flags, so the workflow here should just specify the latter without a need for wasm_sdk_build_command.
There was a problem hiding this comment.
@MaxDesiatov That's incorrect. swift_nightly_flags is not inherited from swift_flags.
There was a problem hiding this comment.
I may be missing something, but there's || inputs.swift_flags on the line you've linked to?
There was a problem hiding this comment.
Yes, I linked to the following line.
BUILD_FLAGS: ${{ (contains(matrix.swift_version, 'nightly') && inputs.swift_nightly_flags) || inputs.swift_flags }}There was a problem hiding this comment.
I don't think so. If swift_nightly_flags is undefined, the first operand of || is falsy, which then evaluates to the second operand swift_flags. You can also see swift_flags respected for nightlies in this workflow, where swift_nightly_flags is not defined at all https://github.com/swiftlang/swift-for-wasm-examples/blob/main/.github/workflows/pull_request.yml
There was a problem hiding this comment.
Sorry, I was wrong. I didn't expect that the empty string was falsy. Thank you.
…3332) Add build check CI for WebAssembly SDK ### Motivation: Add build check CI for WebAssembly SDK ### Modifications: Add Wasm build checks in `main.yml` and `pull_request.yml` based on #3331 Extracted from #3159 ### Result: Setting up the CI job makes it easier to detect such incompatibility before merging.
5 participants
Add build check CI for WebAssembly SDK
Motivation:
Add build check CI for WebAssembly SDK
Modifications:
Add only reusable GHA workflow from #3159 to gracefully merge changes without breaking CI.
After this change being merged into main branch, we can merge the actual PR checks: #3331
Result:
Setting up the CI job makes it easier to detect such incompatibility before merging.