Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BigInt tests] ❌ Binary &&, || and ^ #248

Open
wants to merge 2 commits into
base: biginteger
Choose a base branch
from

Conversation

LiarPrincess
Copy link

Please read the #242 Using tests from “Violet - Python VM written in Swift” before.


❌ Failures

From what I see all of the xor tests fail.

func test_xor_truthTable() {
  typealias Word = BigIntPrototype.Word
  let lhsWord: Word = 0b1100
  let rhsWord: Word = 0b1010

  let lhs = BigInt(.positive, magnitude: lhsWord)
  let rhs = BigInt(.positive, magnitude: rhsWord)

  let expected = BigInt(lhsWord ^ rhsWord)
  XCTAssertEqual(lhs ^ rhs, expected)
  XCTAssertEqual(rhs ^ lhs, expected)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant