Add automated protoc artifact bundle generation for releases #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-protoc-distribution
branch
from
8e7a583 to
f14f281
Compare
thomasvl
reviewed
Aug 12, 2025
Documentation/RELEASING.md
Outdated
|
|
||
| 4. Generate protoc artifact bundle | ||
|
|
||
| Once you have created the draft release, trigger the "Upload protoc artifactbundle" |
There was a problem hiding this comment.
Can any person with commit access to the repo do this?
What if we have two SwiftProtobuf releases without a new protobuf release happening, do we skip this step?
There was a problem hiding this comment.
Can any person with commit access to the repo do this?
Yes
What if we have two SwiftProtobuf releases without a new protobuf release happening, do we skip this step?
Good point. I added a section to check if there is a new release and only then run this.
## Motivation Currently the build plugin distributed from swift-protobuf and other repos that offer protoc plugins such as grpc-swift, are hardly usable since they require the user to install protoc and then point SwiftPM or the IDE to its location. ## Modifications This PR adds a new step in our release flow that bundles the upstream protoc binaries into an artifactbundle and uploads them to the latest draft release. It also adds to the release steps to update the `Package.swift` ## Result We now have an ecosystem wide distributing of protoc that can be used directly from the package manager without requiring users to install it manually. This makes build and command plugins that rely on protoc vastly more useful.
FranzBusch
force-pushed
the
fb-protoc-distribution
branch
from
f14f281 to
32733d5
Compare
thomasvl
approved these changes
Aug 13, 2025
| to reference the new artifact bundle. You'll need to update two things: | ||
|
|
||
| - **URL**: Change to point to your new release tag | ||
| - **Checksum**: Download the artifact bundle and calculate its SHA256 hash |
There was a problem hiding this comment.
Whats the right command line to do that?
There was a problem hiding this comment.
You can do it via the command line by doing swift package compute-checksum <path> but the GH UI will also show it to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the build plugin distributed from swift-protobuf and other repos that offer protoc plugins such as grpc-swift, are hardly usable since they require the user to install protoc and then point SwiftPM or the IDE to its location.
Modifications
This PR adds a new step in our release flow that bundles the upstream protoc binaries into an artifactbundle and uploads them to the latest draft release. It also adds to the release steps to update the
Package.swiftResult
We now have an ecosystem wide distributing of protoc that can be used directly from the package manager without requiring users to install it manually. This makes build and command plugins that rely on protoc vastly more useful.