Fix HRESULT_FACILITY #275
Merged
Fix HRESULT_FACILITY #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HRESULT_FACILITY is >> 16 & 0x1fff, not <<
AZero13
requested review from
glessard,
lorentey and
milseman
as code owners
rauhul
approved these changes
Dec 28, 2025
Contributor
rauhul
left a comment
rauhul
left a comment
There was a problem hiding this comment.
Looks right to me based on https://learn.microsoft.com/en-us/windows/win32/api/winerror/nf-winerror-hresult_facility
Contributor
|
@swift-ci please test |
Contributor
|
@AZero13 could you rebase your PR on top of main? This PR is stuck with outdated CI settings. |
Contributor
Author
Try it now |
Contributor
|
@swift-ci please test |
glessard
approved these changes
Jan 13, 2026
Contributor
|
Thanks @AZero13! This is included in the 1.6.4 tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HRESULT_FACILITY is >> 16 & 0x1fff, not <<