Activity Execution Info to support checking if heartbeat details from previous attempt are available #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this handled by the C# and Ruby SDK? I wasn't able to find a similar method like this in the C# SDK. |
C# SDK exposes the array of heartbeat details here so you can check yourself. |
bauer-andreas
force-pushed
the
andreas-bauer/has-heartbeat-details
branch
from
90229cc to
8965ad7
Compare
bauer-andreas
force-pushed
the
andreas-bauer/has-heartbeat-details
branch
from
8965ad7 to
a114a7f
Compare
bauer-andreas
added
⚠️ semver/major
bauer-andreas
force-pushed
the
andreas-bauer/has-heartbeat-details
branch
2 times, most recently
from
bbb7122 to
a32eab0
Compare
bauer-andreas
force-pushed
the
andreas-bauer/has-heartbeat-details
branch
from
a32eab0 to
722abc3
Compare
FranzBusch
approved these changes
Oct 30, 2025
FranzBusch
added
🆕 semver/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we offer
heartbeatDetails(as:)method to retrieve the activity details of an activity execution. If it's the first attempt, this method fails with an ArgumentErrorMismatched number of values and payloadsas there are no heartbeat details available. The user has no way to differentiate between no heartbeat details being available or that they did indeed supple the wrong amount of payload types.Modifications
We have
heartbeatDetails(as:)return an optional tuple instead, so users can check if there are heartbeat details available from previous activity attempts.Test Plan
Augmented existing unit tests to check activity details to be present or not.