Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AppleCoreBuildStep disabling bitcode on tvOS #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nickfourtimes
Copy link

Bitcode is required on tvOS; building without bitcode causes an error on upload to ASC.

This has been causing an error for me as I'm trying to upload a milestone build; bitcode is becoming disabled in my Unity tvOS builds, & I'd receive the following errors via an email from Apple:

We identified one or more issues with a recent delivery for your app, "XYZ" 0.3 (903). Please correct the following issues, then upload again.

ITMS-90496: Invalid Executable - The executable 'XYZ.app/Frameworks/AppleCoreNative.framework/AppleCoreNative' does not contain bitcode.

ITMS-90496: Invalid Executable - The executable 'XYZ.app/Frameworks/GameKitWrapper.framework/GameKitWrapper' does not contain bitcode.

ITMS-90496: Invalid Executable - The executable 'XYZ.app/Frameworks/UnityFramework.framework/UnityFramework' does not contain bitcode.

ITMS-90496: Invalid Executable - The executable 'XYZ.app/XYZ' does not contain bitcode.

The problem may still persist otherwise, but I felt that this modification was still advised.

Note: I have also noticed that the release notes for Xcode 14 mention that bitcode is being deprecated & is no longer required in tvOS builds, so this fix may no longer be necessary once that version comes out of beta.

Bitcode is required on tvOS; building without bitcode causes an error on upload to ASC
jared-marsau pushed a commit that referenced this pull request Dec 6, 2022
Lower Xcode SDK requirement for accessibility native code
@jared-marsau jared-marsau added the Maintainer Viewed Viewed and undergoing evaluation. label Jan 26, 2023
nickfourtimes and others added 2 commits June 22, 2023 11:41
In the Apple GameController Build Step, while processing info.plist, it's possible that the user has un-selected certain gamepads. If these have been unselected, they should be removed from the resulting info.plist file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Viewed Viewed and undergoing evaluation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants