Update for modern Linux and add Fedora .spec file #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vxi11_open_device function keeps a list of known clients which includes the address. This is a string which can be an IP address (of fixed length) but could also be host names. Change the structure to use a zero-length array for the address and allocate memory according to the address string's length.
The code ignored fgets failures which might lead to undefined behavior and potentially out-of-bound reads. Actually return the error of the loop as the program's exit status
Simplify argument handling in vxi11_send and in the process fix unnecessary truncation of the command and potential out-of-bounds read
This was missing from 'make install'
With this .spec file the package is compiled and packaged in four different RPM files (plus the debug information). The library, header, utilities, and the Python code can be installed separately. The library is a dependency for the other packages, though. Because Fedora (and upstream) for some time has deprecated Python 2 the code is only packaged for Python 3.
Instead of using LIB_SUFFIX simply get the entire directory name from a variable. This matches the variable _lib in RPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Steve,
I have no idea whether you're still interested in this. If not, let me know and I'll just carry on in my cloned repository.
I've been using a hacky build of your vxi11 for a while and only in the last days finally took the steps to update the code for a modern system and create the configuration to create RPM packages. The result works on my Fedora 33 system.
In the process I've fixed potential out-of-bound reads and string truncations.