Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript specs #26

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

JavaScript specs #26

wants to merge 14 commits into from

Conversation

taiar
Copy link
Contributor

@taiar taiar commented May 11, 2016

This PR intends to refactor and write specs for all JavaScript implementation.

A Rake task was made to run both Rspec and Jasmine under travis.ci.

@tlluiz
Copy link

tlluiz commented May 20, 2016

👍

this.clear = function() {
this.storage = [];
this.setStorage();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@taiar taiar force-pushed the feature/js-specs branch from d365b39 to af7fee3 Compare May 23, 2016 17:42
var storage;

beforeEach(function() {
var store = {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'store' is defined but never used.


return {
getTimeSeed: getTimeSeed
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

}

function queue(list) {
if(list != null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use '!==' to compare with 'null'.

},
{
generateID: function(email) {
return email + 'here_we_go'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants