-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript specs #26
base: develop
Are you sure you want to change the base?
JavaScript specs #26
Conversation
👍 |
this.clear = function() { | ||
this.storage = []; | ||
this.setStorage(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
var storage; | ||
|
||
beforeEach(function() { | ||
var store = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'store' is defined but never used.
|
||
return { | ||
getTimeSeed: getTimeSeed | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
} | ||
|
||
function queue(list) { | ||
if(list != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use '!==' to compare with 'null'.
}, | ||
{ | ||
generateID: function(email) { | ||
return email + 'here_we_go' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
This PR intends to refactor and write specs for all JavaScript implementation.
A Rake task was made to run both Rspec and Jasmine under travis.ci.