support pytest python_functions config via a pytest plugin
#157
Conversation
|
@emilybache please review |
| return is_unittest_test or is_pytest_test | ||
| return StackFrameNamer.is_unittest_test( | ||
| frame | ||
| ) or StackFrameNamer.is_pytest_test(method_name) |
There was a problem hiding this comment.
it's bothering me that the StackFrameNamer.is_unittest_test and is_pytest_test take different arguments. I'd pass the frame to both.
| # Check that name looks like a glob-string before calling fnmatch | ||
| # because this is called for every name in each collected module, | ||
| # and fnmatch is somewhat expensive to call. | ||
| elif ("*" in pattern or "?" in pattern or "[" in pattern) and fnmatch.fnmatch( |
There was a problem hiding this comment.
Is this the same code that pytest uses internally? Is there any way to call the same code in pytest as a library?
There was a problem hiding this comment.
Indeed, good eye.
See discussion here.
| @@ -0,0 +1,4 @@ | |||
| from .pytest_config import set_pytest_config | |||
|
|
|||
| def pytest_configure(config): | |||
There was a problem hiding this comment.
I wasnt sure how this was all wired together - what calls pytest_configure?
There was a problem hiding this comment.
This is a pytest plugin, I think pytest treats any function starting with pytest_ in a plugin module as an entry point to the plugin and sends the config as a fixture.
|
I'm a little concerned that this code might solve the immediate problem but not in a sustainable way. It seems to be duplicating functionality in pytest, by reading pytest's configuration file. I wonder if there is a way to re-use the configuration file parsing code from pytest itself? |
|
@emilybache Thanks for reviewing!
Indeed it does, but does not rely on the implementation but rather on the public pytest configuration interface. Copying the code was an easy way to avoid rewriting it, but since there's no obvious way to DRY it I was ok with keeping it as is. I do think that this code merits some unit testing on our side, though. The parsing of the |
|
That is a good response to my concern. It's good to be relying on a public pytest interface. The amount of duplicated code is small and hopefully relatively stable since it refers to the wildcards used in teh published format of the pytest.ini file. |
Co-Authored-By: 4dsherwood <[email protected]> Co-Authored-By: Nitsan Avni <[email protected]> Co-Authored-By: blade290 <[email protected]>
Co-Authored-By: 4dsherwood <[email protected]> Co-Authored-By: Nitsan Avni <[email protected]>
|
looks good to me! |
nitsanavni
changed the title
python_functions config via a pytest plugin
|
Potential starting point for writing test: |
fixes #155 "on my machine"
TODO