Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update readme.md #274

wants to merge 1 commit into from

Conversation

staxmanade
Copy link
Member

update some links that used to reference .js files

This should be small

Small pull requests are great and easy for me to understand and accept
Please try prefix every commits in the pull request with Arlo's git notation

Prefix Meaning
e development enviroment only - not production
d documentation only
t tests only
R!! Refactoring
B!! Bug Fix
F!! New Feature

But it's not small!

Then you should setup a remote pairing session with Llewellyn ( [email protected] )
Usually the sessions are between 45-90 minutes.

assuming you still feel it is small, please include

Description

A description of what the PR achieves.

The solution

Outline the implementation.
Any tests that are affected.

Notation

I prefer lots of very small commits prefixed with Arlo's git notation

update some links that used to reference .js files
Copy link

sourcery-ai bot commented Jul 31, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant