Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common editor form header appearing above entity explorer #38366

Closed
alex-golovanov opened this issue Dec 25, 2024 · 0 comments · Fixed by #38367
Closed

Common editor form header appearing above entity explorer #38366

alex-golovanov opened this issue Dec 25, 2024 · 0 comments · Fixed by #38367
Assignees
@alex-golovanov
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product QA Pod Issues under the QA Pod QA Needs QA attention Task A simple Todo

Comments

@alex-golovanov
Copy link
Contributor

alex-golovanov commented Dec 25, 2024 •
edited
Loading

Header appears to have z-index higher that the one of entity explorer.
image.png
@alex-golovanov alex-golovanov added the IDE Pod Issues that new developers face while exploring the IDE label Dec 25, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Dec 25, 2024
@github-actions github-actions bot removed the IDE Pod Issues that new developers face while exploring the IDE label Dec 25, 2024
@alex-golovanov alex-golovanov self-assigned this Dec 25, 2024
@alex-golovanov alex-golovanov added Bug Something isn't working IDE Product Issues related to the IDE Product labels Dec 25, 2024
@github-actions github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Dec 25, 2024
@alex-golovanov alex-golovanov mentioned this issue Dec 25, 2024
Merged
2 tasks
alex-golovanov added a commit that referenced this issue Dec 26, 2024
@alex-golovanov
fix: common form editor header z-index (#38367)
3334fd7 
## Description
Fixes an issue where common form editor header appears to have z-index
higher that the one of entity explorer.

Fixes #38366 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12493865322>
> Commit: 009a486
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12493865322&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 14:46:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the stacking order of the `FormHeader` component to enhance
its visibility and layering within the user interface.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Dec 26, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Dec 26, 2024
NandanAnantharamu pushed a commit that referenced this issue Dec 27, 2024
@alex-golovanov
fix: common form editor header z-index (#38367)
db4a778 
## Description
Fixes an issue where common form editor header appears to have z-index
higher that the one of entity explorer.

Fixes #38366 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12493865322>
> Commit: 009a486
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12493865322&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 14:46:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the stacking order of the `FormHeader` component to enhance
its visibility and layering within the user interface.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-golovanov alex-golovanov

Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product QA Pod Issues under the QA Pod QA Needs QA attention Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: common form editor header z-index appsmithorg/appsmith
3 participants
@alex-golovanov @Nikhil-Nandagopal @appsmith-bot