Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: common form editor header z-index #38367

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: common form editor header z-index #38367

merged 1 commit into from
Dec 26, 2024

Conversation

alex-golovanov
Copy link
Contributor

@alex-golovanov alex-golovanov commented Dec 25, 2024 •
edited by github-actions bot
Loading

Description

Fixes an issue where common form editor header appears to have z-index higher that the one of entity explorer.

Fixes #38366

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12493865322
Commit: 009a486
Cypress dashboard.
Tags: @tag.IDE
Spec:

Wed, 25 Dec 2024 14:46:11 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Style
    • Updated the stacking order of the FormHeader component to enhance its visibility and layering within the user interface.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2024 •
edited
Loading

Walkthrough

The pull request modifies the z-index of the FormHeader styled component in the CommonEditorForm/styles.ts file. The change reduces the z-index from var(--ads-v2-z-index-21) to var(--ads-v2-z-index-1), which addresses an issue where the form header was appearing above the entity explorer, potentially obscuring underlying UI elements.

Changes

File Change Summary
app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/styles.ts Updated FormHeader component's z-index from high to low value

Assessment against linked issues

Objective Addressed Explanation
Resolve header z-index overlap [#38366] ✅

Possibly related PRs

Suggested labels

Bug, High, IDE Product, ok-to-test, skip-changelog

Suggested reviewers

  • hetunandu

Poem

A z-index dance, layers rearrange
From twenty-one to one, a visual change
Header steps back, explorer takes the stage
UI harmony found on this coded page
🎨✨

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0605501 and 009a486.

📒 Files selected for processing (1)
  • app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/styles.ts (1 hunks)
🔇 Additional comments (1)
app/client/src/PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/styles.ts (1)

20-20: Looks good!

This change correctly lowers the header’s stacking order so that the entity explorer is now on top. Please confirm that the header still appears above any content that it needs to overlay.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo labels Dec 25, 2024
@alex-golovanov
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12493856190.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38367.
recreate: .

@alex-golovanov alex-golovanov added the ok-to-test Required label for CI label Dec 25, 2024
@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-38367.dp.appsmith.com

@alex-golovanov alex-golovanov enabled auto-merge (squash) December 25, 2024 15:24
@alex-golovanov alex-golovanov merged commit 3334fd7 into release Dec 26, 2024
46 checks passed
@alex-golovanov alex-golovanov deleted the fix/38366-common-editor-header-z-index branch December 26, 2024 00:13
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2024
Merged
2 tasks
NandanAnantharamu pushed a commit that referenced this pull request Dec 27, 2024
@alex-golovanov
fix: common form editor header z-index (#38367)
db4a778 
## Description
Fixes an issue where common form editor header appears to have z-index
higher that the one of entity explorer.

Fixes #38366 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12493865322>
> Commit: 009a486
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12493865322&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 14:46:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the stacking order of the `FormHeader` component to enhance
its visibility and layering within the user interface.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product ok-to-test Required label for CI Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common editor form header appearing above entity explorer
2 participants
@alex-golovanov @hetunandu