Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add support for 3D Custom ECharts #26657

Merged
merged 9 commits into from
Sep 27, 2023
Merged

chore: Add support for 3D Custom ECharts #26657

merged 9 commits into from
Sep 27, 2023

Conversation

rajatagrawal
Copy link
Contributor

@rajatagrawal rajatagrawal commented Aug 25, 2023 •
edited
Loading

Fixes #26742

@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5974375255.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 26657.
recreate: .

@ghost
Copy link

ghost commented Aug 25, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-cx01nzwdf-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

@rajatagrawal rajatagrawal removed the request for review from KelvinOm August 25, 2023 10:16
@rajatagrawal
Copy link
Contributor Author

/ok-to-test sha=7ef71b9

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5976906294.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7ef71b9.
PR: 26657.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=26657&runId=5976906294_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5976906294.
Commit: 7ef71b9.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithMultiplePages_spec.ts

  2. cypress/e2e/Regression/ClientSide/Binding/API_with_List_Widget_spec.js
  3. cypress/e2e/Regression/ClientSide/Binding/ChartText_spec.js
  4. cypress/e2e/Regression/ClientSide/Binding/InputWidget_Table_Sorting_spec.js
  5. cypress/e2e/Regression/ClientSide/Binding/SmartSubstitutionWidgets_spec.js
  6. cypress/e2e/Regression/ClientSide/Binding/TabWidget_Input_spec.js
  7. cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js
  8. cypress/e2e/Regression/ClientSide/BugTests/InvalidURL_Spec.ts
  9. cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js
  10. cypress/e2e/Regression/ClientSide/Linting/EntityPropertiesLint_spec.ts
  11. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Replay_Editor_spec.js
  12. cypress/e2e/Regression/ClientSide/Widgets/Chart/ChartDataPoint_Spec.ts
  13. cypress/e2e/Regression/ClientSide/Widgets/Chart/ChartWidgetErrors_spec.ts
  14. cypress/e2e/Regression/ClientSide/Widgets/Text/Text_new_feature_spec.js
  15. cypress/e2e/Regression/ServerSide/ApiTests/API_CurlPOSTImport_spec.js
  16. cypress/e2e/Sanity/Datasources/ArangoDataSourceStub_spec.js
  17. cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts
To know the list of identified flaky tests - Refer here

@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6010435210.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 26657.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-lyaiufhmo-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

Base automatically changed from feat/add-custom-echarts to release August 30, 2023 08:58
@rajatagrawal rajatagrawal requested review from a team, riodeuno and keyurparalkar and removed request for a team August 30, 2023 08:58
@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6024213276.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 26657.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-cf1p2lbgn-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview env=release

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6033392574.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 26657.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://appsmith-dyor06xve-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

@laveena-en
Copy link
Contributor

laveena-en commented Sep 20, 2023 •
edited
Loading

@rajatagrawal The issue with 3D charts not being rendered on switching pages/charts is still persisting: https://www.loom.com/share/a2e5f6ef7e5d4baaaf9a402c9fb3231a?sid=1e83f8ca-0c9f-478b-aaea-08b74be9000e

Can you please take a look?

Ongoing conversation with FE Coders here

@rajatagrawal
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@rajatagrawal
Copy link
Contributor Author

/ok-to-test sha=4cfdf31

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6296493484.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 26657.
recreate: .

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6296494345.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4cfdf31.
PR: 26657.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=26657&runId=6296494345_1

@github-actions
Copy link

Deploy-Preview-URL: https://ce-26657.dp.appsmith.com

@laveena-en
Copy link
Contributor

Tested and verified the changes.

Known issues:

Chart being re-rendered
Eval issue discussion with FE coders
Chart data disappears when browser is idle. Issue raised with e-charts GL here

@laveena-en laveena-en added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Sep 25, 2023
@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6296494345.
Commit: 4cfdf31.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@rajatagrawal
Copy link
Contributor Author

/ok-to-test sha=9281148

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6298341634.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9281148.
PR: 26657.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=26657&runId=6298341634_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6298341634.
Commit: 9281148.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/ActionExecution/RemoveValue_spec.ts

  2. cypress/e2e/Regression/ClientSide/Binding/No_Binding_Prompt_spec.js
  3. cypress/e2e/Regression/ClientSide/BugTests/Bug19893_spec.ts
  4. cypress/e2e/Regression/ClientSide/DynamicHeight/List_TextWidget_Spec.ts
  5. cypress/e2e/Regression/ClientSide/OtherUIFeatures/DynamicLayout_spec.js
  6. cypress/e2e/Regression/ClientSide/PublishedApps/PublishedModeToastToggle_Spec.ts
  7. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePicker2_spec.js
  8. cypress/e2e/Regression/ClientSide/Widgets/JSONForm/JSONForm_FormProperties_spec.js
  9. cypress/e2e/Regression/ClientSide/Widgets/PhoneInput/PhoneInput_Part2_spec.ts
  10. cypress/e2e/Regression/ClientSide/Workspace/LoginFromUIApp_spec.js
  11. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6298341634.
Commit: 9281148.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@rajatagrawal rajatagrawal merged commit 587cc62 into release Sep 27, 2023
17 checks passed
@rajatagrawal rajatagrawal deleted the chore/gl-support-echarts branch September 27, 2023 11:24
rajatagrawal added a commit that referenced this pull request Oct 3, 2023
@rajatagrawal
chore: Add support for 3D Custom ECharts (#26657)
615db14 
Fixes #26742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

Assignees

@rajatagrawal rajatagrawal

Labels
Chart Widget Enhancement New feature or request skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for 3D Custom ECharts
4 participants
@rajatagrawal @laveena-en @Aishwarya-U-R @sbalaji1192