-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default nodeAffinity for subscriptions #34
Conversation
030c771
to
33e2922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up the unnecessary files introduced by component update
. Change itself looks good (I assume you've tested the config on the lab?)
752b263
to
57e65d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docs as well to note that we set a default node selector.
If you move the default config to the library you probably want to update https://github.com/appuio/component-openshift4-operators/blob/master/docs/modules/ROOT/pages/references/component-library.adoc#managedsubscription and https://github.com/appuio/component-openshift4-operators/blob/master/docs/modules/ROOT/pages/references/component-library.adoc#namespacedsubscription and it makes sense to mention the new default node selector in https://github.com/appuio/component-openshift4-operators/blob/master/docs/modules/ROOT/pages/references/parameters.adoc#subscription as well.
57e65d5
to
de3e3e1
Compare
Co-authored-by: Simon Gerber <[email protected]>
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.