Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default nodeAffinity for subscriptions #34

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Sep 6, 2023

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Sep 6, 2023
@DebakelOrakel DebakelOrakel requested a review from a team as a code owner September 6, 2023 08:35
@DebakelOrakel DebakelOrakel changed the title Feat/support node affinity Support default nodeAffinity for subscriptions Sep 6, 2023
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the unnecessary files introduced by component update. Change itself looks good (I assume you've tested the config on the lab?)

.github/workflows/release.yaml.rej Outdated Show resolved Hide resolved
@DebakelOrakel DebakelOrakel force-pushed the feat/support-node-affinity branch 2 times, most recently from 752b263 to 57e65d5 Compare September 6, 2023 12:33
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component/main.jsonnet Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/component-library.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/component-library.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@DebakelOrakel DebakelOrakel merged commit e972ac1 into master Sep 8, 2023
14 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/support-node-affinity branch September 8, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants