-
Notifications
You must be signed in to change notification settings - Fork 20
Implement conditional circuits #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n28div
wants to merge
151
commits into
april-tools:main
Choose a base branch
from
n28div:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,997
−772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il-tools/cirkit into source/symbolic-neural-conditioning
… on arbitrary layer subsets
… parameter sharing in logic circuits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some major changes in cirkit. The main change is the implementation of conditional circuits. This changes parameters to include an additional batch dimension. The change should be as transparent to users as possible. Additionally, the PR includes a routing for backward evaluation of the circuit, which is then used for MAP and sampling queries on the circuit, both with and without evidence.
A functional query on symbolic circuit has been introduced to externally parameterise them. It replaces tensor parameters within a parameter's graph. For now, the query is restricted to work on symbolic circuit that have not been previously transformed, but I suppose the check can be safely removed, I just did not test it thoroughly.
Here is a non-exhaustive list of other changes:
Some features are still not implemented for all layers (for instance, layer maximizations and sampling might be broken on some specific layers). A more comprehensive test suite would help into pinpointing those.