Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syslog log drain doesn't require token #1058

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

syslog log drain doesn't require token #1058

wants to merge 2 commits into from

Conversation

michaelwang13
Copy link
Member

Remove the requirement for Syslog Log Drains to have a token. The CLI and old dashboard do/did not have this requirement.

@michaelwang13 michaelwang13 changed the title syslog doesn't require token syslog log drain doesn't require token Mar 3, 2025
@michaelwang13 michaelwang13 requested a review from benjodo March 3, 2025 16:50
UserNotFound
UserNotFound requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@UserNotFound UserNotFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just get rid of the validation on loggingToken, since we're skipping it for both of the drain types that actually accept it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UserNotFound UserNotFound UserNotFound requested changes

@benjodo benjodo Awaiting requested review from benjodo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelwang13 @UserNotFound