Fix error handling for invalid scenario names and numbers#8
Open
davidlin2k wants to merge 2 commits intoaqm-eval-suite:masterfrom
Open
Fix error handling for invalid scenario names and numbers#8davidlin2k wants to merge 2 commits intoaqm-eval-suite:masterfrom
davidlin2k wants to merge 2 commits intoaqm-eval-suite:masterfrom
Conversation
…r valid scenario numbers and names, providing error messages for invalid inputs. Improved scenario execution logic for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve error handling and validation for scenario names and numbers in the
src/aqm-eval-suite/examples/aqm-eval-suite-runner.ccfile. The most important changes include adding checks for invalid scenario numbers, providing user feedback for invalid inputs, and ensuring that scenario names are validated before execution.Error handling improvements:
scenarioNumberand provide an error message if it is invalid, including a list of valid scenario numbers.scenarioNameto ensure it is either "All", "RttFairness", or a valid scenario name from theScenarioNumberMapping. If invalid, an error message is displayed with a list of valid scenario names.Code simplification:
Example: