Skip to content

fix: rename notebook to load #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpopesculian wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: rename notebook to load #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/aqora_cli/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing_extensions import Any, TypedDict, override

from . import _aqora_cli
from .notebook import notebook
from .notebook import load
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check if __all__ is defined and whether it needs to include 'load'

# Check for __all__ definition in __init__.py
rg -n '__all__' python/aqora_cli/__init__.py -A10

# If __all__ exists, verify 'load' is included
ast-grep --pattern '__all__ = $$$'

Repository: aqora-io/cli

Length of output: 248

Add explicit __all__ definition to the module's __init__.py to properly expose the public API.

The load import is correct, but python/aqora_cli/__init__.py lacks an __all__ definition. Other modules in this package (e.g., pyarrow.py, fsspec.py) explicitly define their public API. Add __all__ to python/aqora_cli/__init__.py to include load and any other intended public exports, ensuring consistency across the package.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@python/aqora_cli/__init__.py` at line 4, Add an explicit __all__ export list
to this package init to match other modules: update python/aqora_cli/__init__.py
(which currently imports load from .notebook) to declare __all__ = ["load"] (and
include any additional public names you intend to export). Ensure the exported
symbol name matches the imported function name load so the package exposes the
public API consistently with modules like pyarrow.py and fsspec.py.

from aqora_cli._aqora_cli import * # pyright: ignore[reportAssignmentType, reportWildcardImportFromLibrary] # noqa: F403


Expand Down
2 changes: 1 addition & 1 deletion python/aqora_cli/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def _load_module(owner: str, slug: str, filename: str, path: Path) -> ModuleType
return module


def notebook(
def load(
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve notebook alias for backward compatibility

Renaming the public function from notebook to load removes an existing API entry point and will break callers that upgraded from the previous release and still do from aqora_cli.notebook import notebook (or import notebook from aqora_cli). In those environments, imports now fail immediately, so this should keep a notebook = load alias (optionally deprecated) rather than hard-renaming the symbol in a fix commit.

Useful? React with 👍 / 👎.

workspace: str,
*,
filename: str | None = None,
Expand Down
Loading