Minor additions to the tests

aragon · May 10, 2024 · c118413 · c118413
1 parent d72f85e
commit c118413
Showing 1 changed file with 37 additions and 1 deletion.
diff --git a/packages/contracts/test/unit-testing/main-voting-plugin.ts b/packages/contracts/test/unit-testing/main-voting-plugin.ts
@@ -2394,6 +2394,12 @@ describe('Tests replicated from the original AddressList plugin', async () => {
           .false;
         expect(await mainVotingPlugin.isSupportThresholdReached(id)).to.be.true;
         expect(await mainVotingPlugin.canExecute(id)).to.be.false;
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
 
         // 2
         await mainVotingPlugin
@@ -2406,13 +2412,25 @@ describe('Tests replicated from the original AddressList plugin', async () => {
           .false;
         expect(await mainVotingPlugin.isSupportThresholdReached(id)).to.be.true;
         expect(await mainVotingPlugin.canExecute(id)).to.be.false;
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
 
         await advanceAfterVoteEnd(endDate);
 
         expect(await mainVotingPlugin.isMinParticipationReached(id)).to.be
           .false;
         expect(await mainVotingPlugin.isSupportThresholdReached(id)).to.be.true;
         expect(await mainVotingPlugin.canExecute(id)).to.be.false;
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
       });
 
       it('does not execute if participation is high enough but support is too low', async () => {
@@ -2432,13 +2450,24 @@ describe('Tests replicated from the original AddressList plugin', async () => {
         expect(await mainVotingPlugin.isSupportThresholdReachedEarly(id)).to.be
           .false;
         expect(await mainVotingPlugin.canExecute(id)).to.be.false;
-
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
         await advanceAfterVoteEnd(endDate);
 
         expect(await mainVotingPlugin.isMinParticipationReached(id)).to.be.true;
         expect(await mainVotingPlugin.isSupportThresholdReached(id)).to.be
           .false;
         expect(await mainVotingPlugin.canExecute(id)).to.be.false;
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
       });
 
       it('executes after the duration if participation and support thresholds are met', async () => {
@@ -2497,6 +2526,13 @@ describe('Tests replicated from the original AddressList plugin', async () => {
 
         expect(await mainVotingPlugin.addresslistLength()).to.eq(5);
 
+        await expect(mainVotingPlugin.execute(id))
+          .to.be.revertedWithCustomError(
+            mainVotingPlugin,
+            'ProposalExecutionForbidden'
+          )
+          .withArgs(id);
+
         // 1
         await mainVotingPlugin
           .connect(signers[0])