Fix PHP warnings in print_code() #466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$toolbar_height and $info_height use $font_size but that variable is a string with 'px !important;' at the end and so the multiplication causes php notices (PHP Notice: A non well formed numeric value encountered in /wp-content/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 119). My code uses $_font_size which just contains a number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$toolbar_height and $info_height use $font_size but that variable is a string with 'px !important;' at the end and so the multiplication causes php notices (PHP Notice: A non well formed numeric value encountered in /wp-content/plugins/crayon-syntax-highlighter/crayon_formatter.class.php on line 119). My code uses $_font_size which just contains a number.