Fix warnings #38
Open
Fix warnings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachThread can't be static. InitializeDll.h doesn't exist. Returning const values makes no sense. Add some missing standard headers includes.
Add include of <algorithm> for std::min and std::max Define NOMINMAX so this can work Add include of <cstddef> Tiny bit of _MSC_VER fixing for MinGW-w64 plans
Remove isinff(x) replacing it with !isfinite(x) (or _finite on Windows MSVC < 2013)
.. where appropriate.
|
Would it be possible to get a review for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all the warnings I could squeeze out of as many compilers as I could get my hands on.