-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly request a context version. #66
Open
computerquip
wants to merge
1
commit into
aras-p:master
Choose a base branch
from
computerquip:mesa-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesa doesn't support ARB_compatibility. It also doesn't default to the latest context. We can either make a context and test GL_VERSION... or just try to make contexts until we get one we can use.
Tried checking out pr/66 and got a similar error
|
I might of misunderstood how FreeGLUT would react to this patch. I'll look into it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mesa doesn't default to the latest context. We can either make a context, test GL_VERSION, and parse the result... or just use GLEW and test versions until we get a minimum of each level we need for a given GLSL version.
Alternatively, we can get rid of freeglut and create a GLX/Xlib context with pixmap. I don't really think it's worth the trouble though...
The code looks odd but it's easy to explain. glewInit is below of freeglut window initialization because glew requires a context to work. This context isn't created in glutInit but glutCreateWindow. We also have no way to create a context with the desired settings... so we create a dummy context to fetch capabilities, set the capabilities, destroy the dummy context/window, and create a new context/window with desired settings. A core profile is required because Mesa does not support ARB_compatibility.