Skip to content

feat(mobile): polish terminal inbox - #382

Merged
AprilNEA merged 2 commits into
masterfrom
xuan/code-530
Aug 1, 2026
Merged

AprilNEA merged 2 commits into
masterfrom
xuan/code-530

Conversation

@AprilNEA

@AprilNEA AprilNEA commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

  • move terminal creation into the native header and a SwiftUI bottom sheet
  • add native empty, loading, and error states with focus refresh
  • show cwd, shell, grid size, and controller state in terminal rows

Why

The terminal inbox mixed creation controls with its list, used a form row as an empty state, and could show stale or oldest-first data. Creation failures were also presented as loading failures.

Validation

  • pnpm check:ci
  • pnpm test — 2,390 passed, 1 skipped
  • iPhone 17 Pro / iOS 26.5 Simulator — empty state, create sheet, create/list refresh, termination cleanup, and create failure

Stack

  • Depends on xuan/code-526.

Known baseline issue

  • pnpm -F @linkcode/mobile smoke:export is blocked by stale CODE-526 route assertions for removed app/host/[hostId]/** routes.

@linear-code

linear-code Bot commented Aug 1, 2026

Copy link
Copy Markdown

CODE-530

AprilNEA added a commit that referenced this pull request Aug 1, 2026
## Summary

- move the mobile shell to root-level native tabs with a stacked UIKit
search bar and native header actions
- keep Settings and the host switcher reachable while disconnected, with
pooled host connections and an opt-in keep-connected preference
- enrich thread rows and use a direct UIKit blur view for the
navigation-bar backdrop

## Why

The previous route hierarchy tied navigation to the selected host, hid
the escape path when that host was unreachable, and recreated system
navigation chrome in app UI. Thread rows also omitted agent, project,
and recency context already available in the schema.

## Validation

- `pnpm check:ci` — passed on stacked descendant `xuan/code-530`
- `pnpm test` — 2,390 passed, 1 skipped on stacked descendant
`xuan/code-530`
- iPhone 17 Pro / iOS 26.5 Simulator — search activate/type/cancel, tab
switching, host switching, thread rows, and navigation-bar backdrop

## Notes

- Last-message previews remain deferred because transcripts are
provider-local history rather than session-list data.
- Follow-up PR #382 is intentionally stacked on this branch.
- The branch is currently behind `master`; this stays draft until it is
updated and checks are rerun on the rebased branch.
Base automatically changed from xuan/code-526 to master August 1, 2026 19:18
@AprilNEA
AprilNEA marked this pull request as ready for review August 1, 2026 19:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ce526d774

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/mobile/src/app/(tabs)/terminals/index.tsx
@AprilNEA
AprilNEA merged commit 9fe21a1 into master Aug 1, 2026
10 checks passed
@AprilNEA
AprilNEA deleted the xuan/code-530 branch August 1, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant