fix(chat): make smooth conversation follow opt-in - #385
Merged
Merged
Conversation
AprilNEA
marked this pull request as ready for review
August 1, 2026 18:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
virtuasettles its measured row sizesRoot cause
Conversationusedinitial="instant"but retainedresize="smooth".use-stick-to-bottomappliesinitialonly to the first observed height; switching sessions remounts the conversation, andvirtuathen reports additional positive resizes while replacing estimates with measured rows. Those later resizes entered the smooth spring path, so the newly selected conversation visibly scrolled even though its initial positioning was instant. The dependency's instant path also waits forrequestAnimationFrame, which left a visible intermediate position during measurement settling.Impact
Switching conversations now opens directly at the latest message without a scroll animation. Users who prefer animated following can opt in from Appearance settings.
Verification
pnpm check:cipnpm test— 302 files passed, 3 skipped; 2,435 tests passed, 5 skippedpnpm -F @linkcode/webview e2e:browseritemSize={300}mounts all 48 fixture turns and fails the< 10bound; the restored implementation mounts 6 and passesTracks CODE-259.