fix(mobile): align Live Activity target name for EAS signing - #389
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkCode Agent Activitydisplay nameRoot cause
@bacons/apple-targetssanitizedLinkCode Agent Activityto the EAS target nameLinkCodeAgentActivity, while Expo provisioning looked upPBXNativeTarget.nameby exact equality. The generated Xcode target retained spaces, so the production iOS build failed duringConfigure Xcode project.Impact
Production EAS builds can assign the existing widget provisioning profile to the generated Live Activity target.
Validation
targetName: LinkCodeAgentActivityfindNativeTargetByNamelookup succeeds against the generated projectpnpm check:cipnpm test— 2,439 passed, 1 skippedpnpm -F @linkcode/mobile smoke:export— Android and iOS passedLinear: CODE-534