Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failed popup when clicking search result marker in default deny #11503

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Sep 26, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Prevent the marker popup from failing when clicking a search result while using the default deny permission framework. Hard-coded permission types are still in the map.js viewmodel. This could be avoided with an instance permission endpoint as described here

Issues Solved

Closes #11501

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@aarongundel aarongundel merged commit 54af0c5 into dev/7.6.x Sep 27, 2024
7 checks passed
@aarongundel aarongundel deleted the cnh/11501_fix_popup_for_default_deny branch September 27, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants